Skip to content

fix(incidents): use correct RBAC scopes for delete and read endpoints (fixes #5363) #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asheesh-devops wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(incidents): use correct RBAC scopes for delete and read endpoints (fixes #5363) #6225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions keep/api/routes/incidents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ def update_incident(
def bulk_delete_incidents(
incident_ids: List[UUID] = Body(..., embed=True),
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["write:incident"])
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
),
pusher_client: Pusher | None = Depends(get_pusher_client),
session: Session = Depends(get_session),
Expand All @@ -445,7 +445,7 @@ def bulk_delete_incidents(
def delete_incident(
incident_id: UUID,
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["write:incident"])
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
),
pusher_client: Pusher | None = Depends(get_pusher_client),
session: Session = Depends(get_session),
Expand Down Expand Up @@ -549,7 +549,7 @@ def get_incident_alerts(
offset: int = 0,
include_unlinked: bool = False,
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
IdentityManagerFactory.get_auth_verifier(["read:incident"])
),
) -> AlertWithIncidentLinkMetadataPaginatedResultsDto:
tenant_id = authenticated_entity.tenant_id
Expand Down Expand Up @@ -601,7 +601,7 @@ def get_future_incidents_for_an_incident(
limit: int = 25,
offset: int = 0,
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
IdentityManagerFactory.get_auth_verifier(["read:incident"])
),
) -> IncidentsPaginatedResultsDto:
tenant_id = authenticated_entity.tenant_id
Expand Down Expand Up @@ -653,7 +653,7 @@ def get_incident_workflows(
limit: int = 25,
offset: int = 0,
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
IdentityManagerFactory.get_auth_verifier(["read:incident"])
),
) -> WorkflowExecutionsPaginatedResultsDto:
"""
Expand Down Expand Up @@ -718,7 +718,7 @@ def delete_alerts_from_incident(
incident_id: UUID,
fingerprints: List[str],
authenticated_entity: AuthenticatedEntity = Depends(
IdentityManagerFactory.get_auth_verifier(["write:incident"])
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
),
session=Depends(get_session),
pusher_client: Pusher | None = Depends(get_pusher_client),
Expand Down
Loading