Serde Deserialize+Serialize implementation#440
Open
rabbit-time wants to merge 3 commits intokeepsimple1:mainfrom
Open
Serde Deserialize+Serialize implementation#440rabbit-time wants to merge 3 commits intokeepsimple1:mainfrom
rabbit-time wants to merge 3 commits intokeepsimple1:mainfrom
Conversation
Author
|
CI jobs are currently failing since clippy isn't being run with features enabled. Line 1286 in |
keepsimple1
reviewed
Mar 10, 2026
Owner
keepsimple1
left a comment
keepsimple1
left a comment
There was a problem hiding this comment.
Looks good! One inline comment related to the CI error. And optional, if you have bandwidth, you can also add a new step in CI to run cargo clippy --tests --all-features -- -D warnings to cover the features (I think).
| assert!(service_info.is_address_supported(&intf_loopback_v6)); | ||
| } | ||
|
|
||
| #[test] |
Owner
There was a problem hiding this comment.
You can add #[cfg(feature = "serde")] here, which would also fix the CI error, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature flag:
serdeI've implemented the
SerializeandDeserializetraits usingderiveforResolvedServiceand for all the local types which it contains.Additionally, I've also written a basic test to accompany the changes and added
serde_jsonas a development dependency.If there is a benefit to providing
serdesupport for types other thanResolvedService, please comment that.Closes: #438