-
-
Notifications
You must be signed in to change notification settings - Fork 282
Remove deprecated v4.0.0 docs and improve spacing consistency #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Summary of IssuesThe CSS file contains literal Impact: The spacing rules for Files Reviewed (6 files)
|
Signed-off-by: Atishay Tripathi <atishay1922@gmail.com>
dc76a67 to
d53c2dc
Compare
| margin-bottom: 1.5rem !important; /* Consistent space after images */ | ||
| } | ||
|
|
||
| article \u003e div[style*='backgroundColor'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: Invalid CSS selector - \u003e should be >
The literal string \u003e is being used instead of the > (child combinator) character. This CSS selector will not work as intended.
| article \u003e div[style*='backgroundColor'] { | |
| article > div[style*='backgroundColor'] { |
| } | ||
|
|
||
| /* Fix the large top margin on first element after header */ | ||
| .markdown \u003e *:first-child, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: Invalid CSS selector - \u003e should be >
Same issue as above - the literal string \u003e should be replaced with the > character.
| .markdown \u003e *:first-child, | |
| .markdown > *:first-child, |
|
|
||
| /* Fix the large top margin on first element after header */ | ||
| .markdown \u003e *:first-child, | ||
| article \u003e .markdown \u003e *:first-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: Invalid CSS selector - \u003e should be >
Multiple occurrences of \u003e that should be > characters.
| article \u003e .markdown \u003e *:first-child { | |
| article > .markdown > *:first-child { |
🚀 PR Changelog: Version Consolidation & Technical RefinementThis commit consolidates the documentation versioning structure, promoting the latest features to Version 3.0.0 and archiving obsolete data. It also preserves critical technical fixes for build stability and editor performance. 🔄 What was Undone/Restored
✅ What was Preserved (Not Undone)
🚀 Version Migration (v4.0.0 → v3.0.0)
📁 File Changes Summary
📚 Related IssuesCloses https://github.com/keploy/product/issues/9 🛠️ Build Status: PASSINGThe project has been verified with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR description
🚀 Comprehensive PR Description: Documentation Refinement & Version Consolidation
This PR represents a systematic overhaul of the Keploy documentation to improve maintainability, resolve build-breaking routing conflicts, and enhance the overall reading experience. Below is a detailed section-by-section breakdown of every change made since the
mainbranch.🛠️ Core Configuration & Infrastructure Changes
importtorequireto fix module resolution errors in the editor ($ts-check). SetlastVersion: "3.0.0"and restored stable analytics logic.unist-util-visit"4.0.0"["3.0.0", "2.0.0", "1.0.0"], making the latest features the default "maintained" version.🎨 UI & User Experience Refinements
th) tovertical-align: top, ensuring information alignment in multi-line comparison tables.📂 Documentation Versioning & Structural Promotion
1. Version 3.0.0 Promotion (The New Maintained Version)
Originally located in version 4.0.0, these files have been promoted to Version 3.0.0 to represent the current state-of-the-art.
.../server/linux/installation.mdid: installation→id: linux-installation.../server/windows/installation.mdid: installation→id: windows-installation.../server/macos/installation.mdid: installation→id: macos-installation.../quickstart/sample-apps.md.../keploy-cloud/kubernetes-local-setup.md.../running-keploy/api-testing-auth-setup.md2. Version 3.0.0 Archive (Data Preservation)
The original Version 3.0.0 content has been preserved to avoid any data loss while keeping the active site clean.
version-3.0.0content toversioned_docs/version-3.0.0-archive/.📸 Visual Evidence
1. Sidebar Reference Fix
The promotion of content required updating the
idtags to prevent circular or duplicate references.2. Typography & Spacing
Applied global CSS to ensure headings have enough
line-heightso that descenders (j, p, q, y) are not visually clipped by the container overflow.Applied global CSS to ensure headings have enough
line-heightso that descenders (j, p, q, y) are not visually clipped by the container overflow.✅ Checklist
npm run buildwith zero routing or duplicate ID errors.