WIP: version 670

.claude-plugin/plugin.json

@@ -0,0 +1,4 @@
+{
+  "name": "keybase-client-skills",
+  "description": "Development skills for the Keybase client repo"
+}

.claude/hooks/pre-commit-check.sh

@@ -0,0 +1,20 @@
+#!/bin/bash
+
+REPO_ROOT=$(git -C "$(dirname "$0")" rev-parse --show-toplevel)
+
+if [ ! -d "$REPO_ROOT/shared/node_modules" ]; then
+  echo "node_modules not installed — skipping lint/tsc." >&2
+  exit 0
+fi
+
+if ! (cd "$REPO_ROOT/shared" && yarn lint 2>&1); then
+  echo "Lint failed — commit blocked." >&2
+  exit 2
+fi
+
+if ! (cd "$REPO_ROOT/shared" && yarn tsc 2>&1); then
+  echo "TypeScript check failed — commit blocked." >&2
+  exit 2
+fi
+
+echo "Pre-commit checks passed." >&2

.claude/settings.json

@@ -0,0 +1,34 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(yarn lint)",
+      "Bash(yarn lint-warn:*)",
+      "Bash(yarn prettier:*)",
+      "Bash(yarn build-*)",
+      "Bash(yarn package)",
+      "Bash(yarn start*)",
+      "Bash(yarn rn-gobuild*)",
+      "Bash(yarn rn-download-android*)",
+      "Bash(yarn tsc)",
+      "Bash(yarn tsc:*)",
+      "Bash(yarn pod*)",
+      "Bash(yarn coverage:*)",
+      "Bash(yarn maestro*)"
+    ]
+  },
+  "hooks": {
+    "PreToolUse": [
+      {
+        "matcher": "Bash(git commit*)",
+        "hooks": [
+          {
+            "type": "command",
+            "command": ".claude/hooks/pre-commit-check.sh",
+            "timeout": 120,
+            "statusMessage": "Running lint and tsc..."
+          }
+        ]
+      }
+    ]
+  }
+}

.claude/skills

@@ -0,0 +1 @@
+../skill

.gitignore

@@ -87,6 +87,5 @@ go/keybase_netbsd
 go/keybase_openbsd
 
 .cursor
-.claude
+.claude/settings.local.json
 .*-mcp
-CLAUDE.md

AGENTS.md

@@ -0,0 +1,4 @@
+# Repo Notes
+
+- This repo uses React Compiler. Assume React Compiler patterns are enabled when editing React code, and avoid adding `useMemo`/`useCallback` by default unless they are clearly needed for correctness or compatibility with existing code.
+- When a component reads multiple adjacent values from the same store hook, prefer a consolidated selector with `C.useShallow(...)` instead of multiple separate subscriptions.

CLAUDE.md

@@ -0,0 +1,19 @@
+## Rules
+- No `Co-Authored-By` in commits. Ever.
+- "Was working before" = base branch (`nojima/HOTPOT-next-670-clean` or `master`), not previous commit.
+- Never use `npm`. Always `yarn`.
+- Never silently drop features/behavior — ask first, present options.
+- No DOM elements (`<div>`, `<span>`, etc.) in plain `.tsx` files — use `Kb.*`. Guard desktop-only DOM with `Styles.isMobile`.
+- Temp files go in `/tmp/`.
+- Remove unused code when editing: styles, imports, vars, params, dead helpers.
+- Comments: no refactoring notes; only add when context isn't obvious from code.
+- Exact versions in `package.json` (no `^`/`~`).
+- Keep `react`, `react-dom`, `react-native`, `@react-native/*` in sync with Expo SDK.
+- When updating deps: edit `package.json` → `yarn` → `yarn pod-install`.
+- When updating `electron`: run `shared/desktop/extract-electron-shasums.sh <version>`.
+
+## Working Directory
+Repo root is `client/`. TS source lives in `shared/`. Always use absolute paths for file ops. For Bash: always `cd shared/` first.
+
+## Validation
+After TS changes (from `shared/`): `yarn lint` then `yarn tsc`. When debugging visually, skip until fix is confirmed. Never delete the ESLint cache.

go/auth/credential_authority_test.go

@@ -59,7 +59,7 @@ func newTestUser(nKeys int) *testUser {
 		sibkeys:  make([]keybase1.KID, nKeys),
 		subkeys:  make([]keybase1.KID, nKeys),
 	}
-	for i := 0; i < nKeys; i++ {
+	for i := range nKeys {
 		ret.sibkeys[i] = genKID()
 		ret.subkeys[i] = genKID()
 	}
@@ -236,7 +236,7 @@ func TestSimple(t *testing.T) {
 	u1 := state.newTestUser(4)
 
 	ng := 3
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		err = credentialAuthority.CheckUserKey(context.TODO(), u1.uid, &u1.username, &u1.sibkeys[0], false)
 		if err != nil {
 			t.Fatal(err)
@@ -283,7 +283,7 @@ func TestCheckUsers(t *testing.T) {
 	state, credentialAuthority := newTestSetup()
 
 	var users, usersWithDud []keybase1.UID
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		u := state.newTestUser(2)
 		users = append(users, u.uid)
 		usersWithDud = append(usersWithDud, u.uid)

go/avatars/fileurilze_nix.go

@@ -1,5 +1,4 @@
 //go:build !windows
-// +build !windows
 
 package avatars
 

go/avatars/fileurlize_windows.go

@@ -1,5 +1,4 @@
 //go:build windows
-// +build windows
 
 package avatars
 

go/avatars/fullcaching.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"maps"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -97,10 +98,10 @@ type FullCachingSource struct {
 
 	prepareDirs sync.Once
 
-	usersMissBatch  func(interface{})
-	teamsMissBatch  func(interface{})
-	usersStaleBatch func(interface{})
-	teamsStaleBatch func(interface{})
+	usersMissBatch  func(any)
+	teamsMissBatch  func(any)
+	usersStaleBatch func(any)
+	teamsStaleBatch func(any)
 
 	// testing
 	populateSuccessCh chan struct{}
@@ -116,16 +117,16 @@ func NewFullCachingSource(g *libkb.GlobalContext, staleThreshold time.Duration,
 		staleThreshold: staleThreshold,
 		simpleSource:   NewSimpleSource(),
 	}
-	batcher := func(intBatched interface{}, intSingle interface{}) interface{} {
+	batcher := func(intBatched any, intSingle any) any {
 		reqs, _ := intBatched.([]remoteFetchArg)
 		single, _ := intSingle.(remoteFetchArg)
 		return append(reqs, single)
 	}
-	reset := func() interface{} {
+	reset := func() any {
 		return []remoteFetchArg{}
 	}
-	actor := func(loadFn func(libkb.MetaContext, []string, []keybase1.AvatarFormat) (keybase1.LoadAvatarsRes, error)) func(interface{}) {
-		return func(intBatched interface{}) {
+	actor := func(loadFn func(libkb.MetaContext, []string, []keybase1.AvatarFormat) (keybase1.LoadAvatarsRes, error)) func(any) {
+		return func(intBatched any) {
 			reqs, _ := intBatched.([]remoteFetchArg)
 			s.makeRemoteFetchRequests(reqs, loadFn)
 		}
@@ -213,7 +214,7 @@ func (c *FullCachingSource) StartBackgroundTasks(mctx libkb.MetaContext) {
 	c.started = true
 	go c.monitorAppState(mctx)
 	c.populateCacheCh = make(chan populateArg, 100)
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		go c.populateCacheWorker(mctx)
 	}
 	mctx, cancel := mctx.WithContextCancel()
@@ -238,7 +239,7 @@ func (c *FullCachingSource) StopBackgroundTasks(mctx libkb.MetaContext) {
 	}
 }
 
-func (c *FullCachingSource) debug(m libkb.MetaContext, msg string, args ...interface{}) {
+func (c *FullCachingSource) debug(m libkb.MetaContext, msg string, args ...any) {
 	m.Debug("Avatars.FullCachingSource: %s", fmt.Sprintf(msg, args...))
 }
 
@@ -266,7 +267,7 @@ func (c *FullCachingSource) monitorAppState(m libkb.MetaContext) {
 
 func (c *FullCachingSource) processLRUHit(entry lru.DiskLRUEntry) (res lruEntry) {
 	var ok bool
-	if _, ok = entry.Value.(map[string]interface{}); ok {
+	if _, ok = entry.Value.(map[string]any); ok {
 		jstr, _ := json.Marshal(entry.Value)
 		_ = json.Unmarshal(jstr, &res)
 		return res
@@ -488,9 +489,7 @@ func (c *FullCachingSource) makeURL(m libkb.MetaContext, path string) keybase1.A
 
 func (c *FullCachingSource) mergeRes(res *keybase1.LoadAvatarsRes, m keybase1.LoadAvatarsRes) {
 	for username, rec := range m.Picmap {
-		for format, url := range rec {
-			res.Picmap[username][format] = url
-		}
+		maps.Copy(res.Picmap[username], rec)
 	}
 }
 

go/avatars/simple.go

@@ -2,6 +2,7 @@ package avatars
 
 import (
 	"fmt"
+	"maps"
 	"strings"
 
 	"github.com/keybase/client/go/libkb"
@@ -63,14 +64,12 @@ func (s *SimpleSource) makeRes(res *keybase1.LoadAvatarsRes, apiRes apiAvatarRes
 	allocRes(res, names)
 	for index, rec := range apiRes.Pictures {
 		u := names[index]
-		for format, url := range rec {
-			res.Picmap[u][format] = url
-		}
+		maps.Copy(res.Picmap[u], rec)
 	}
 	return nil
 }
 
-func (s *SimpleSource) debug(m libkb.MetaContext, msg string, args ...interface{}) {
+func (s *SimpleSource) debug(m libkb.MetaContext, msg string, args ...any) {
 	m.Debug("Avatars.SimpleSource: %s", fmt.Sprintf(msg, args...))
 }
 

go/avatars/srv.go

@@ -64,12 +64,12 @@ func (s *Srv) GetUserAvatar(username string) (string, error) {
 	return fmt.Sprintf("http://%v/av?typ=user&name=%v&format=square_192&token=%v", addr, username, token), nil
 }
 
-func (s *Srv) debug(msg string, args ...interface{}) {
+func (s *Srv) debug(msg string, args ...any) {
 	s.G().GetLog().Debug("Avatars.Srv: %s", fmt.Sprintf(msg, args...))
 }
 
 func (s *Srv) makeError(w http.ResponseWriter, code int, msg string,
-	args ...interface{},
+	args ...any,
 ) {
 	s.debug("serve: error code: %d msg %s", code, fmt.Sprintf(msg, args...))
 	w.WriteHeader(code)

go/avatars/urlcaching.go

@@ -2,6 +2,7 @@ package avatars
 
 import (
 	"fmt"
+	"maps"
 	"time"
 
 	"github.com/keybase/client/go/libkb"
@@ -36,7 +37,7 @@ func (c *URLCachingSource) StopBackgroundTasks(m libkb.MetaContext) {
 	c.diskLRU.Flush(m.Ctx(), m.G())
 }
 
-func (c *URLCachingSource) debug(m libkb.MetaContext, msg string, args ...interface{}) {
+func (c *URLCachingSource) debug(m libkb.MetaContext, msg string, args ...any) {
 	m.Debug("Avatars.URLCachingSource: %s", fmt.Sprintf(msg, args...))
 }
 
@@ -89,9 +90,7 @@ func (c *URLCachingSource) specLoad(m libkb.MetaContext, names []string, formats
 
 func (c *URLCachingSource) mergeRes(res *keybase1.LoadAvatarsRes, m keybase1.LoadAvatarsRes) {
 	for username, rec := range m.Picmap {
-		for format, url := range rec {
-			res.Picmap[username][format] = url
-		}
+		maps.Copy(res.Picmap[username], rec)
 	}
 }
 

go/bind/dns_ios.go

@@ -2,7 +2,6 @@
 // this source code is governed by the included BSD license.
 //
 //go:build ios
-// +build ios
 
 package keybase
 

go/bind/dns_other.go

@@ -2,7 +2,6 @@
 // this source code is governed by the included BSD license.
 //
 //go:build !ios
-// +build !ios
 
 package keybase
 

go/bind/keybase.go

@@ -60,7 +60,7 @@ var (
 )
 
 // log writes to kbCtx.Log if available, otherwise falls back to fmt.Printf
-func log(format string, args ...interface{}) {
+func log(format string, args ...any) {
 	msg := fmt.Sprintf(format, args...)
 	if kbCtx != nil && kbCtx.Log != nil {
 		kbCtx.Log.Info(msg)
@@ -446,7 +446,7 @@ func LogSend(statusJSON string, feedback string, sendLogs, sendMaxBytes bool, tr
 	return string(logSendID), err
 }
 
-// WriteArr sends raw bytes encoded msgpack rpc payload, ios only
+// WriteArr sends raw bytes encoded msgpack rpc payload from the native layer (iOS and Android)
 func WriteArr(b []byte) (err error) {
 	bytes := make([]byte, len(b))
 	copy(bytes, b)

go/bind/keystore_android.go

@@ -2,7 +2,6 @@
 // this source code is governed by the included BSD license.
 
 //go:build android
-// +build android
 
 package keybase