fix: clear Windows taskbar overlay icon when badge count reaches 0#29053
Open
omahabrad wants to merge 1 commit intokeybase:masterfrom
Open
fix: clear Windows taskbar overlay icon when badge count reaches 0#29053omahabrad wants to merge 1 commit intokeybase:masterfrom
omahabrad wants to merge 1 commit intokeybase:masterfrom
Conversation
When desktopAppBadgeCount drops to 0, the overlay variable was set to null and the short-circuit && prevented setOverlayIcon from ever being called. The previous dot would stay on the taskbar indefinitely. Fix by explicitly calling setOverlayIcon(null, '') to clear the overlay when count is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When desktopAppBadgeCount drops to 0, the overlay variable was set to null and the short-circuit && prevented setOverlayIcon from ever being called. The previous dot would stay on the taskbar indefinitely. Fix by explicitly calling setOverlayIcon(null, '') to clear the overlay when count is 0.