Skip to content

simplify node side startup#29061

Open
chrisnojima-zoom wants to merge 3 commits intonojima/HOTPOT-next-670-cleanfrom
nojima/ZCLIENT-app-clean-1
Open

simplify node side startup#29061
chrisnojima-zoom wants to merge 3 commits intonojima/HOTPOT-next-670-cleanfrom
nojima/ZCLIENT-app-clean-1

Conversation

@chrisnojima-zoom
Copy link
Contributor

  • test

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Electron “node/main process” startup path to consolidate the previous node2.desktop entrypoint into node.desktop, while splitting app event registration into clearer, composable functions.

Changes:

  • Removed node2.desktop.tsx and moved its startup logic into node.desktop.tsx with a more structured runtime/deferred-launch flow.
  • Refactored app-events.desktop.tsx into targeted “register*” functions (crash handling, navigation guards, open handlers, lifecycle handlers, power monitor, second-instance).
  • Adjusted menubar initialization to load its URL on the menubar instance’s ready event, and updated IPC handler dependency naming (onAppStartedUpmarkAppStartedUp).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
shared/desktop/app/node2.desktop.tsx Deleted legacy node-side startup entrypoint; logic now centralized elsewhere.
shared/desktop/app/node.desktop.tsx New primary startup orchestration (module loading, deferred launch flushing, lifecycle wiring, whenReady flow).
shared/desktop/app/app-events.desktop.tsx Extracted/renamed startup event wiring into focused registration helpers used by node.desktop.tsx.
shared/desktop/app/ipc-handlers.desktop.tsx Renamed startup callback dependency and updated the appStartedUp IPC action to invoke it.
shared/desktop/app/menu-bar.desktop.tsx Loads menubar window URL on mb.on('ready') instead of relying on Electron.app.on('ready').

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants