simplify node side startup#29061
Open
chrisnojima-zoom wants to merge 3 commits intonojima/HOTPOT-next-670-cleanfrom
Open
simplify node side startup#29061chrisnojima-zoom wants to merge 3 commits intonojima/HOTPOT-next-670-cleanfrom
chrisnojima-zoom wants to merge 3 commits intonojima/HOTPOT-next-670-cleanfrom
Conversation
Contributor
chrisnojima-zoom
commented
Mar 25, 2026
- test
There was a problem hiding this comment.
Pull request overview
Refactors the Electron “node/main process” startup path to consolidate the previous node2.desktop entrypoint into node.desktop, while splitting app event registration into clearer, composable functions.
Changes:
- Removed
node2.desktop.tsxand moved its startup logic intonode.desktop.tsxwith a more structured runtime/deferred-launch flow. - Refactored
app-events.desktop.tsxinto targeted “register*” functions (crash handling, navigation guards, open handlers, lifecycle handlers, power monitor, second-instance). - Adjusted menubar initialization to load its URL on the menubar instance’s
readyevent, and updated IPC handler dependency naming (onAppStartedUp→markAppStartedUp).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/desktop/app/node2.desktop.tsx | Deleted legacy node-side startup entrypoint; logic now centralized elsewhere. |
| shared/desktop/app/node.desktop.tsx | New primary startup orchestration (module loading, deferred launch flushing, lifecycle wiring, whenReady flow). |
| shared/desktop/app/app-events.desktop.tsx | Extracted/renamed startup event wiring into focused registration helpers used by node.desktop.tsx. |
| shared/desktop/app/ipc-handlers.desktop.tsx | Renamed startup callback dependency and updated the appStartedUp IPC action to invoke it. |
| shared/desktop/app/menu-bar.desktop.tsx | Loads menubar window URL on mb.on('ready') instead of relying on Electron.app.on('ready'). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.