Skip to content

simpler people components#29062

Open
chrisnojima-zoom wants to merge 1 commit intonojima/HOTPOT-next-670-cleanfrom
nojima/ZCLIENT-people-simpler
Open

simpler people components#29062
chrisnojima-zoom wants to merge 1 commit intonojima/HOTPOT-next-670-cleanfrom
nojima/ZCLIENT-people-simpler

Conversation

@chrisnojima-zoom
Copy link
Contributor

  • test

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the People screen UI code to reduce repetition by introducing small reusable components/helpers for rendering todo tasks and item lists.

Changes:

  • Consolidates multiple “todo” connector components into reusable BasicTask, SwitchTabTask, SettingsAccountTask, and OpenURLTask building blocks.
  • Simplifies People list rendering by extracting renderPeopleItem, shouldRenderNewItem, and PeopleItems.
  • Small behavioral-preserving cleanups (shared router selector hook, minor callback simplification).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
shared/people/todo.tsx Replaces many per-todo connector components with a small set of reusable task components and a shared router selector helper.
shared/people/index.shared.tsx Extracts item rendering/filtering into helper functions/components to reduce inline JSX complexity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants