Skip to content

chore(common): cleanup data types for kmx-plus-file 🔱#15789

Merged
mcdurdin merged 2 commits intoepic/embed-osk-in-kmxfrom
chore/common/embed-osk/15752-cleanup
Apr 16, 2026
Merged

chore(common): cleanup data types for kmx-plus-file 🔱#15789
mcdurdin merged 2 commits intoepic/embed-osk-in-kmxfrom
chore/common/embed-osk/15752-cleanup

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

Addresses comments in #15752 review.

Test-bot: skip
See-also: #15752

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Mar 26, 2026

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title chore(common): cleanup data types for kmx-plus-file chore(common): cleanup data types for kmx-plus-file 🔱 Mar 26, 2026
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S25 milestone Mar 26, 2026
@mcdurdin mcdurdin marked this pull request as ready for review March 27, 2026 04:55
@mcdurdin mcdurdin requested a review from ermshiperete March 27, 2026 04:55
@keyman-server keyman-server modified the milestones: A19S25, A19S26 Mar 28, 2026
Comment thread common/web/types/src/kmx/kmx-plus/kmx-plus-file.ts Outdated
Comment thread common/web/types/src/kmx/kmx-plus/kmx-plus-file.ts Outdated
@keyman-server keyman-server modified the milestones: A19S26, A19S27 Apr 14, 2026
@mcdurdin mcdurdin force-pushed the change/developer/embed-osk/remove-font-data-from-osk branch from 79d4bdd to 2e38a50 Compare April 16, 2026 07:13
mcdurdin and others added 2 commits April 16, 2026 09:15
Addresses comments in #15752 review.

Test-bot: skip
See-also: #15752
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
@mcdurdin mcdurdin force-pushed the chore/common/embed-osk/15752-cleanup branch from 4be89fe to c985808 Compare April 16, 2026 07:15
Base automatically changed from change/developer/embed-osk/remove-font-data-from-osk to epic/embed-osk-in-kmx April 16, 2026 20:16
@mcdurdin mcdurdin merged commit 54868b0 into epic/embed-osk-in-kmx Apr 16, 2026
24 checks passed
@mcdurdin mcdurdin deleted the chore/common/embed-osk/15752-cleanup branch April 16, 2026 20:17
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants