feat(developer): add kmap support to KMX+ kvk and keyman-touch-layout 🔱#15821
Merged
mcdurdin merged 3 commits intoepic/embed-osk-in-kmxfrom Apr 16, 2026
Merged
feat(developer): add kmap support to KMX+ kvk and keyman-touch-layout 🔱#15821mcdurdin merged 3 commits intoepic/embed-osk-in-kmxfrom
mcdurdin merged 3 commits intoepic/embed-osk-in-kmxfrom
Conversation
github-actions
bot
added
web/
developer/
common/
developer/compilers/
common/web/
docs
feat
labels
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
mcdurdin
commented
Apr 9, 2026
ermshiperete
approved these changes
Apr 9, 2026
| return layerBags; | ||
| } | ||
|
|
||
| private addKmap(keys: KMXPlus.Keys, newKey: KMXPlus.KeysKeys, vkey: number, mod: number) { |
Contributor
There was a problem hiding this comment.
Better name might be addToKmap (or even addToKeymap or addKeyToKmap)
|
|
||
| assert.isArray(keys.kmap); | ||
| assert.isEmpty(keys.kmap); | ||
| assert.lengthOf(keys.kmap, keys.keys.length); |
Contributor
There was a problem hiding this comment.
From devin.ai:
KVK kmap test only checks length, not modifier values
The KVK embedding test at embed-osk-kvk.tests.ts:118 was updated from assert.isEmpty(keys.kmap) to assert.lengthOf(keys.kmap, keys.keys.length) but does not validate the actual content of kmap entries (vkey, mod values). This means the bug where key.shift (VisualKeyboardShiftState) is passed instead of the LDML modifier to addKmap is not caught by the test suite. Adding content assertions (similar to what the touch layout test does at embed-osk-touch-layout.tests.ts:176-181) would have caught this issue.
mcdurdin
force-pushed
the
chore/common/embed-osk/15752-cleanup
branch
from
4be89fe to
c985808
Compare
Refactor the `getModifierState` and `getStateFromLayer` functions into a cleaner `modifierStringToState` function, and move from web into common. Marks existing functions as deprecated but does not update usage at this time.
Add mappings for key to vkey + mod for .kvk and .keyman-touch-layout, and clarify the key identifiers for .keyman-touch-layout within KMX+ format. Update unit test fixture khmer_angkor.keyman_touch_layout to remove dependency on .kmn (T_xxxx_yyyy -> U_xxxx_yyyy), as the relevant VKDictionary will not be present, because the corresponding .kmn is not compiled for the unit tests where the fixture is used. Test-bot: skip
mcdurdin
force-pushed
the
feat/developer/embed-osk/kmap
branch
from
2399324 to
401c0db
Compare
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Base automatically changed from
chore/common/embed-osk/15752-cleanup
to
epic/embed-osk-in-kmx
April 16, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mappings for key to vkey + mod for .kvk and .keyman-touch-layout, and clarify the key identifiers for .keyman-touch-layout within KMX+ format.
Update unit test fixture khmer_angkor.keyman_touch_layout to remove dependency on .kmn (T_xxxx_yyyy -> U_xxxx_yyyy), as the relevant VKDictionary will not be present, because the corresponding .kmn is not compiled for the unit tests where the fixture is used.
Also refactor the
getModifierStateandgetStateFromLayerfunctions into a cleanermodifierStringToStatefunction, and move from web into common.Marks existing functions as deprecated but does not update usage at this time.
Test-bot: skip