change(web): simplify model.predict() calls 🚂#15851
Draft
jahorton wants to merge 1 commit intochange/web/suggestion-rangefrom
Draft
change(web): simplify model.predict() calls 🚂#15851jahorton wants to merge 1 commit intochange/web/suggestion-rangefrom
jahorton wants to merge 1 commit intochange/web/suggestion-rangefrom
Conversation
Rather than copying over part of the existing context just to delete it, we can simplify prediction calls by just pre-deleting the current token, then applying any relevant deleteLeft transform component afterward to resulting predictions. Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
web/
web/predictive-text/
change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than copying over part of the existing context just to delete it, we can simplify prediction calls by just pre-deleting the current token, then applying any relevant deleteLeft transform component afterward to resulting predictions.
🚧 Is incomplete; this approach is better designed to follow the work started #15818 once #15782 is better integrated.
Build-bot: skip build:web
Test-bot: skip