Imply --workspace when running in workspace root#535
Closed
Logarithmus wants to merge 1 commit intokillercup:masterfrom
Closed
Imply --workspace when running in workspace root#535Logarithmus wants to merge 1 commit intokillercup:masterfrom
--workspace when running in workspace root#535Logarithmus wants to merge 1 commit intokillercup:masterfrom
Conversation
Logarithmus
force-pushed
the
feat/cargo-workspace-by-default
branch
from
2ed18d7 to
26a2985
Compare
epage
reviewed
Nov 11, 2021
Aims for saner defaults & to match `cargo update` behavior
Logarithmus
force-pushed
the
feat/cargo-workspace-by-default
branch
from
26a2985 to
28ee3f7
Compare
epage
requested changes
Nov 11, 2021
|
|
||
| /// Check if local manifest is virtual, i. e. corresponds to workspace root | ||
| pub fn is_virtual(&self) -> bool { | ||
| !self.data["workspace"].is_none() |
Collaborator
There was a problem hiding this comment.
The existence of a workspace table does not make it virtual. To be virtual, it also needs to not have a package.
Check out https://github.com/crate-ci/clap-cargo/blob/master/src/workspace.rs#L29 for a good approximation of what cargo does.
Author
There was a problem hiding this comment.
OK, I'll fix it a bit later.
Collaborator
There was a problem hiding this comment.
Alternatively, we could just port the project over to clap-cargo.
Author
There was a problem hiding this comment.
clap-cargo look like an amazing project! I'm willing to help with the porting.
Draft
Author
|
Closing in favor of #537 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims for saner defaults & to match
cargo updatebehavior