Rename Promise to a different name#84
Open
patocallaghan wants to merge 1 commit intokimroen:masterfrom
Open
Conversation
|
I recommend submitting your pull request at https://github.com/mike-north/ember-cli-document-title until the owner of this repo responds. |
Author
|
Oh thanks, I didn't know that existed. I'm using my own fork atm too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a weird one 😄
I bumped to 0.4.0 from 0.3.3 and noticed some of my tests were failing even though they had nothing to do with ember-cli-document-title. Turns out that
var Promisewas clobberingwindow.Promisewhich caused issues. Because the addon code is in a vendor file it just gets inlined as is into the vendor.js which means any variables defined here are global. Here I've renamedPromisetoRSVPromiseto prevent any clobbering.