Fix iconTint ignored in ShieldConfiguration#91
Merged
robertherber merged 2 commits intomainfrom Feb 19, 2026
Merged
Conversation
Co-authored-by: robertherber <1467411+robertherber@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix iconTint effect on shield icon
Fix iconTint ignored in ShieldConfiguration
Feb 18, 2026
commit: |
There was a problem hiding this comment.
Pull request overview
Fixes shield icon tinting in the ShieldConfiguration extension by applying the result of UIImage.withTintColor instead of discarding it, ensuring iconTint actually affects the rendered icon.
Changes:
- Assign the tinted image back to
imagewheniconTintis provided. - Use
.alwaysOriginalrendering mode to prevent the system from overriding the tint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iconTintparameter was silently ignored when configuring shield icons.UIImage.withTintColor(_:)returns a new instance rather than mutating—the tinted image was created and immediately discarded.Changes
withTintColorresult back toimagevariable.alwaysOriginalrendering mode to prevent system overrideLocation:
packages/react-native-device-activity/targets/ShieldConfiguration/ShieldConfigurationExtension.swift:64Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.