Merged
Conversation
Rishabh-git10
requested review from
Jwilliamsr,
amisevsk,
bmicklea,
gorkem,
javisperez and
jfuss
as code owners
Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
Rishabh-git10
force-pushed
the
feat/1069-prompt-support
branch
from
e36c729 to
dfee303
Compare
Collaborator
|
@Rishabh-git10 Thanks for taking this up! Overall this looks fine to me but could you add some validation to https://github.com/kitops-ml/pykitops/blob/main/tests/test_kitfile_output.py#L9 and https://github.com/kitops-ml/pykitops/blob/main/tests/test_kitfile_output.py#L63. You can follow what we have already. I don't see any issues this would cause but more to ensure we don't run into something in the future. |
Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
Contributor
Author
|
Done! Added explicit assertions for the prompts block in |
jfuss
approved these changes
Feb 25, 2026
Collaborator
|
@Rishabh-git10 Thanks for the contribution and time you put into this! I am planning to have this deployed by end of week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves kitops-ml/kitops#1069
Description
This PR adds support for the
promptslayer within thePykitopsSDK to achieve parity with the core CLI updates (kitops-ml/kitops#948).Changes Made:
PromptEntryto_pydantic_kit.pyto validate prompt paths and descriptions.promptsgetter/setter properties toPydanticKitfile.Kitfilewrapper docstrings and examples.tests/fixtures/Kitfile_fullto include a mockpromptsblock to ensurepytestcatches serialization/deserialization.All tests are passing locally.