refactor(api,cli): split resume selector from bootstrap skipping #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The -r flag now only sets the resume=true selector and no longer skips rule discovery and bootstrap scripts. To achieve the previous behavior of skipping bootstrap, users must now use both -r and --skip-bootstrap flags together. The change separates concerns: - -r: Sets resume selector for task filtering - --skip-bootstrap: Controls whether to discover rules, skills, and run bootstrap scripts This allows users to independently control task filtering and bootstrap behavior, providing more flexibility in workflow configurations. API changes: - Added WithBootstrap() option in options.go to control bootstrap behavior programmatically - WithResume() now only sets the resume selector and no longer affects bootstrap discovery - Context.doBootstrap field controls rule/skill discovery and bootstrap script execution independently from resume selector
swedishborgie
commented
Jan 28, 2026
| { | ||
| name: "command output not trimmed", | ||
| content: "!`echo -n hello` world", | ||
| content: "!`printf 'hello'` world", |
Collaborator
Author
There was a problem hiding this comment.
This was to resolve a POSIX compatibility issue on macOS.
alexec
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The -r flag now only sets the resume=true selector and no longer skips rule discovery and bootstrap scripts. To achieve the previous behavior of skipping bootstrap, users must now use both -r and --skip-bootstrap flags together.
The change separates concerns:
This allows users to independently control task filtering and bootstrap behavior, providing more flexibility in workflow configurations.
API changes: