Conversation
still has many broken tests
sample_rate is now an attribute of preprocessor, and an attribute of each AudioSample during preprocessing therefore, sample_rate should not be a property in BasePreprocessor subclasses, and AudioClipLoader action no longer has a sample_rate key in 'params' Co-authored-by: Copilot <copilot@github.com>
this model architecture requires lots of custom code, conditionals, and workarounds, and is never used, so I'm removing it. Users could implement based on the removed code if needed.
pass sample_rate to init also use placeholder Identity as model.network rather than a heavy resnet18, since the OnnxModel does not use the .network attribute Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
sammlapp
commented
May 1, 2026
| """Initialize the HopliteDataset | ||
|
|
||
| #TODO: to go fast, do we need to do batched retrieval? | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Check on up to date retrieval method for hoplite
| return emb, self.label_df.iloc[idx].values | ||
|
|
||
|
|
||
| def fit_on_hoplite_db( |
Collaborator
Author
There was a problem hiding this comment.
Check hoplite training script and compare strategy
…ssifier / SpectrogramModule also update docstring for collate_fn in safeaudiodataloader Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.