Merged
Conversation
58b358d to
7afd7da
Compare
87f16ae to
7152f01
Compare
7152f01 to
8ec52ce
Compare
AndreMiras
reviewed
Jan 1, 2026
Member
AndreMiras
left a comment
There was a problem hiding this comment.
Awesome work, looks good overall, pretty clear and nice feature thank you!
I just have a few remarks and concerns I'd like to discuss.
- It would be nice to have at least some basic unit tests for
is_wheel_platform_independent()(that one should be relatively easy) andprocess_python_modules()(that one is more tricky, but let's try to have at least some basic coverage). I noticed the code currently bypasses the new logic whenrecipe_build_orderis a Mock - having proper tests would let us remove that workaround. - Have we thought of having a
--no-auto-resolveor something like that for reproducible builds? - A bit tricky to integration test, I imagine that would mean having an app build with the requirements list not fully defined/pinned and test it runtime, but then we have some build reproducibility concerns. Do you have some ideas for how to make sure your changes don't get broken later on without us realising?
ff7a141 to
6ca4f29
Compare
Member
Author
I think an integration test would be overkill here. The modules list is highly variable, and all of this work is handled by pip itself. |
kuzeyron
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3274
Package resolution is performed using the hostpython's
pipvia the--dry-runoption.Example
Output:
