ci: upgrade Node.js from EOL v18 to v20 in update workflows#3532
ci: upgrade Node.js from EOL v18 to v20 in update workflows#3532Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
Node.js 18 reached End of Life in April 2024. Upgrade to Node.js 20 (current LTS) across all three update workflows to ensure security patches and compatibility with modern packages. Fixes knative#3528
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @Ankitsinghsisodya! It looks like this is your first PR to knative/func 🎉 |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js runtime used by scheduled “update-*” GitHub Actions workflows, moving them off EOL Node 18 and onto Node 20 (current LTS) for continued security support.
Changes:
- Bump
actions/setup-nodenode-versionfrom18to"20"in three scheduled update workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/update-ca-bundle.yaml | Updates workflow Node.js version to 20 for the CA bundle update script. |
| .github/workflows/update-quarkus-platform.yaml | Updates workflow Node.js version to 20 for the Quarkus platform update script. |
| .github/workflows/update-springboot-platform.yaml | Updates workflow Node.js version to 20 for the Spring Boot platform update script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node-version: "20" | ||
| - name: Install NPM deps. | ||
| run: npm install octokit@3.2.1 |
There was a problem hiding this comment.
|
Thanks for catching that @copilot. The |
Summary
node-versionfrom18to"20"inupdate-ca-bundle.yaml,update-quarkus-platform.yaml, andupdate-springboot-platform.yamlTest plan
Update CA bundlescheduled workflow runs successfully with Node 20Update Quarkus Platformworkflow runs successfully with Node 20Update Spring Boot Platformworkflow runs successfully with Node 20Fixes #3528