Skip to content

ci: upgrade Node.js from EOL v18 to v20 in update workflows#3532

Open
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/upgrade-nodejs-18-to-20
Open

ci: upgrade Node.js from EOL v18 to v20 in update workflows#3532
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/upgrade-nodejs-18-to-20

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown

Summary

  • Upgrades node-version from 18 to "20" in update-ca-bundle.yaml, update-quarkus-platform.yaml, and update-springboot-platform.yaml
  • Node.js 18 reached End of Life in April 2024; Node.js 20 is the current LTS with active security support

Test plan

  • Verify Update CA bundle scheduled workflow runs successfully with Node 20
  • Verify Update Quarkus Platform workflow runs successfully with Node 20
  • Verify Update Spring Boot Platform workflow runs successfully with Node 20

Fixes #3528

Node.js 18 reached End of Life in April 2024. Upgrade to Node.js 20
(current LTS) across all three update workflows to ensure security
patches and compatibility with modern packages.

Fixes knative#3528
Copilot AI review requested due to automatic review settings March 27, 2026 19:35
@knative-prow knative-prow bot requested review from dsimansk and jrangelramos March 27, 2026 19:35
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 27, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Ankitsinghsisodya / name: Ankit sisodya (f129b60)

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

Welcome @Ankitsinghsisodya! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Mar 27, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Node.js runtime used by scheduled “update-*” GitHub Actions workflows, moving them off EOL Node 18 and onto Node 20 (current LTS) for continued security support.

Changes:

  • Bump actions/setup-node node-version from 18 to "20" in three scheduled update workflows.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/update-ca-bundle.yaml Updates workflow Node.js version to 20 for the CA bundle update script.
.github/workflows/update-quarkus-platform.yaml Updates workflow Node.js version to 20 for the Quarkus platform update script.
.github/workflows/update-springboot-platform.yaml Updates workflow Node.js version to 20 for the Spring Boot platform update script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +19 to 21
node-version: "20"
- name: Install NPM deps.
run: npm install octokit@3.2.1
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is marked as fixing #3528, but the workflows still use npm install (e.g., here) rather than the npm ci change described in the issue. Either implement the npm ci/lockfile approach for these update scripts, or adjust the issue/PR linkage so it doesn’t claim to fully address #3528.

Copilot uses AI. Check for mistakes.
@Ankitsinghsisodya
Copy link
Copy Markdown
Author

Thanks for catching that @copilot. The npm ci change was removed from the PR during implementation because these workflows use ad-hoc npm install <package>@<version> without a package.json or package-lock.json — so npm ci would not work here. I've updated the issue description (#3528) to remove the npm ci reference. The PR now accurately matches the issue scope (Node.js version upgrade only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: upgrade Node.js from EOL v18 to v20 in update workflows

2 participants