Skip to content

ci: remove redundant single-entry matrix in test-podman-next workflow#3533

Open
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/remove-redundant-matrix-podman-next
Open

ci: remove redundant single-entry matrix in test-podman-next workflow#3533
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/remove-redundant-matrix-podman-next

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown

Summary

  • Removes the strategy.matrix block in test-podman-next.yaml which contained only one entry (ubuntu-latest)
  • Replaces the indirect runs-on: ${{ matrix.os }} with the direct runs-on: ubuntu-latest
  • No behaviour change — simplifies the workflow and makes the intent clearer

Test plan

  • Confirm the Func Podman Next Test workflow still triggers on schedule and runs on ubuntu-latest

Fixes #3529

The strategy matrix defined a single OS entry (ubuntu-latest) and then
referenced it via matrix.os. This adds indirection with no benefit.
Replace with a direct runs-on value.

Fixes knative#3529
Copilot AI review requested due to automatic review settings March 27, 2026 19:36
@knative-prow knative-prow bot requested review from dsimansk and jrangelramos March 27, 2026 19:36
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 27, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Ankitsinghsisodya / name: Ankit sisodya (16547b9)

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Mar 27, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies the scheduled “Func Podman Next Test” GitHub Actions workflow by removing an unnecessary single-entry matrix, keeping behavior the same while making the workflow easier to read.

Changes:

  • Removes the strategy.matrix block that only contained ubuntu-latest.
  • Replaces runs-on: ${{ matrix.os }} with runs-on: ubuntu-latest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: remove redundant single-entry matrix in test-podman-next workflow

2 participants