Skip to content

ci: add timeout-minutes to all jobs in functions.yaml #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ankitsinghsisodya wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

ci: add timeout-minutes to all jobs in functions.yaml #3535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
precheck:
name: Precheck
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- uses: knative/actions/setup-go@main
Expand Down Expand Up @@ -59,6 +60,7 @@ jobs:
- "macos-14" # ARM
- "windows-latest"
runs-on: ${{ matrix.os }}
timeout-minutes: 30
steps:
- name: Disable CRLF conversion (Windows)
if: runner.os == 'Windows'
Expand Down Expand Up @@ -94,6 +96,7 @@ jobs:
- "macos-14" # ARM
- "windows-latest"
runs-on: ${{ matrix.os }}
timeout-minutes: 60
steps:
# Setup
- name: Disable CRLF conversion (Windows)
Expand Down Expand Up @@ -131,6 +134,7 @@ jobs:
name: Integration Tests
needs: precheck
runs-on: ubuntu-latest
timeout-minutes: 120
env:
FUNC_CLUSTER_RETRIES: 5
FUNC_INT_TEKTON_ENABLED: true
Expand Down Expand Up @@ -194,6 +198,7 @@ jobs:
name: E2E - Core, Metadata, and Remote
needs: precheck
runs-on: ubuntu-latest
timeout-minutes: 120
env:
FUNC_CLUSTER_RETRIES: 5
FUNC_E2E_CLEAN: false # cluster only used once
Expand Down Expand Up @@ -248,6 +253,7 @@ jobs:
name: E2E - Podman
needs: precheck
runs-on: ubuntu-latest
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e-podman defines a strategy.matrix.os, but runs-on is hardcoded to ubuntu-latest, so both matrix entries run on the same runner label. This likely defeats the intent of testing on ARM (ubuntu-24.04-arm) and also duplicates CI work. Consider changing runs-on to use matrix.os (or removing the matrix if only one runner is intended).

Suggested change
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@Ankitsinghsisodya Ankitsinghsisodya Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — this is a pre-existing issue in the workflow, not introduced by this PR. The test-e2e-podman job hardcodes runs-on: ubuntu-latest while defining a matrix with both ubuntu-latest and ubuntu-24.04-arm, so both matrix entries run on the same x86_64 runner. This should be fixed separately. I'll keep this PR scoped to adding timeout-minutes only.

timeout-minutes: 120
strategy:
matrix:
os:
Expand Down Expand Up @@ -312,6 +318,7 @@ jobs:
- "quarkus"
- "springboot"
runs-on: ubuntu-latest
timeout-minutes: 90
env:
FUNC_CLUSTER_RETRIES: 5 # Cluster allocation retries
FUNC_E2E_CLEAN: false # Skip deletes (cluster not reused)
Expand Down Expand Up @@ -391,6 +398,7 @@ jobs:
name: E2E - Config CI GitHub Workflows
needs: precheck
runs-on: ubuntu-latest
timeout-minutes: 120
env:
FUNC_CLUSTER_RETRIES: 5
FUNC_E2E_CLEAN: false
Expand Down Expand Up @@ -451,6 +459,7 @@ jobs:
- test-e2e-config-ci
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: knative/actions/setup-go@main
Expand Down Expand Up @@ -489,6 +498,7 @@ jobs:
name: Publish Utils Image
needs: build
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: knative/actions/setup-go@main
Expand Down Expand Up @@ -531,6 +541,7 @@ jobs:
name: Publish as Image
needs: build
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: knative/actions/setup-go@main
Expand Down
Loading