ci: fix test-e2e-podman to use matrix.os instead of hardcoded runner#3538
ci: fix test-e2e-podman to use matrix.os instead of hardcoded runner#3538Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
The job defines a matrix with ubuntu-latest (x86_64) and ubuntu-24.04-arm (ARM64) but runs-on was hardcoded to ubuntu-latest, so both matrix entries ran on x86_64. Use the matrix value so ARM64 tests actually run on ARM hardware. Fixes knative#3537
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Fixes the test-e2e-podman GitHub Actions job so its OS matrix actually runs on the intended runner for each entry (x86_64 and ARM64), ensuring ARM coverage is exercised on ARM hardware as intended.
Changes:
- Switch
test-e2e-podmanfrom a hardcodedruns-on: ubuntu-latesttoruns-on: ${{ matrix.os }}. - Ensure the matrix’s
ubuntu-24.04-armentry executes on an ARM runner rather than duplicating the x86_64 run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| strategy: | ||
| matrix: | ||
| os: | ||
| - "ubuntu-latest" # x86_64 | ||
| - "ubuntu-24.04-arm" # ARM64 | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
test-e2e-podman uses a matrix but doesn’t set strategy.fail-fast: false. Other matrix jobs in this workflow (e.g., test-unit, test-templates) disable fail-fast so all OS/arch variants still run even if one fails. Consider doing the same here so an early failure on one runner doesn’t cancel the other architecture’s run.
Summary
test-e2e-podmanjob which defines a matrix withubuntu-latest(x86_64) andubuntu-24.04-arm(ARM64) but hadruns-on: ubuntu-latesthardcodedruns-on: ${{ matrix.os }}so each matrix entry runs on the correct runnerTest plan
E2E - Podmanjob spawns two matrix runs: one onubuntu-latestand one onubuntu-24.04-armFixes #3537