Skip to content

ci: fix test-e2e-podman to use matrix.os instead of hardcoded runner#3538

Open
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/fix-e2e-podman-matrix-runs-on
Open

ci: fix test-e2e-podman to use matrix.os instead of hardcoded runner#3538
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/fix-e2e-podman-matrix-runs-on

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown

Summary

  • Fixes test-e2e-podman job which defines a matrix with ubuntu-latest (x86_64) and ubuntu-24.04-arm (ARM64) but had runs-on: ubuntu-latest hardcoded
  • Both matrix entries were running on x86_64, so ARM64 was never actually tested on ARM hardware
  • Changed to runs-on: ${{ matrix.os }} so each matrix entry runs on the correct runner

Test plan

  • Verify the E2E - Podman job spawns two matrix runs: one on ubuntu-latest and one on ubuntu-24.04-arm
  • Confirm both matrix entries complete successfully

Fixes #3537

The job defines a matrix with ubuntu-latest (x86_64) and
ubuntu-24.04-arm (ARM64) but runs-on was hardcoded to ubuntu-latest,
so both matrix entries ran on x86_64. Use the matrix value so ARM64
tests actually run on ARM hardware.

Fixes knative#3537
Copilot AI review requested due to automatic review settings March 27, 2026 20:02
@knative-prow knative-prow bot requested review from dsimansk and jrangelramos March 27, 2026 20:02
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Mar 27, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 27, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the test-e2e-podman GitHub Actions job so its OS matrix actually runs on the intended runner for each entry (x86_64 and ARM64), ensuring ARM coverage is exercised on ARM hardware as intended.

Changes:

  • Switch test-e2e-podman from a hardcoded runs-on: ubuntu-latest to runs-on: ${{ matrix.os }}.
  • Ensure the matrix’s ubuntu-24.04-arm entry executes on an ARM runner rather than duplicating the x86_64 run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 250 to +255
strategy:
matrix:
os:
- "ubuntu-latest" # x86_64
- "ubuntu-24.04-arm" # ARM64
runs-on: ${{ matrix.os }}
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e-podman uses a matrix but doesn’t set strategy.fail-fast: false. Other matrix jobs in this workflow (e.g., test-unit, test-templates) disable fail-fast so all OS/arch variants still run even if one fails. Consider doing the same here so an early failure on one runner doesn’t cancel the other architecture’s run.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: test-e2e-podman ignores ARM matrix entry due to hardcoded runs-on

2 participants