Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds collapsible behavior to the Component/Styles/Preview panels and updates the grid layout to support collapsed states across default and side-preview layouts.
Changes:
- Introduces panel collapse toggle buttons and collapsed-state styling for vertical/horizontal collapse.
- Refactors the main grid layout to group editors into a stack area and adjust sizing rules for side preview layouts.
- Adds Playwright coverage for collapse behavior and side-layout sizing/scrolling constraints.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/panels-editor.css | Adds collapse toggle styling and collapsed-state UI rules for the three panels. |
| src/styles/layout-shell.css | Refactors grid areas/layout rules to support an editors stack and collapsed panel widths/heights. |
| src/index.html | Adds collapse toggle buttons and wraps component/styles panels in an editors stack container. |
| src/app.js | Implements collapse state management, axis/direction rules per layout, and side-preview height syncing. |
| playwright/app.spec.ts | Adds E2E tests for collapse behavior and side-layout sizing/scrolling rules. |
| docs/next-steps.md | Notes follow-up work to replace JS height syncing with a CSS-only approach. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds collapsible/expandable behavior and “tools” visibility toggles to the editor and preview panels, along with layout/scrolling adjustments to keep the UI usable across stacked and side-by-side layouts.
Changes:
- Introduces panel collapse toggles (vertical/horizontal depending on active layout) and editor “tools” toggles for Component/Styles panels.
- Refactors the app grid to use an editors stack area and tightens height/overflow rules so preview/editor scrolling stays contained.
- Removes the style warning footer UX and updates defaults/tests accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/preview-controls.css | Adjusts preview host flex/min/max sizing to behave correctly inside the new constrained layout. |
| src/styles/panels-editor.css | Adds styling for collapse/tool toggles and collapsed panel states; introduces .panel-content wrapper behavior. |
| src/styles/layout-shell.css | Refactors the grid layout to support an editors stack area and collapsed/side layouts with constrained heights. |
| src/styles/base.css | Updates page-level sizing/overflow to support a full-height app shell on desktop while allowing scroll on mobile. |
| src/modules/render-runtime.js | Removes style warning update logic from the render runtime. |
| src/modules/defaults.js | Switches the default example styling hook from #counter-button to .counter-button. |
| src/index.html | Updates panel markup to add collapse/tool controls and wraps content in .panel-content; removes the style warning footer. |
| src/app.js | Adds UI state + event handlers for panel collapse and tools visibility; syncs button state/attributes to layout. |
| playwright/app.spec.ts | Adds E2E coverage for collapse axis/direction behavior, “not all collapsed” rule, tools toggles, and layout sizing. |
| eslint.config.js | Enforces no-unused-vars for Playwright-related files. |
| docs/next-steps.md | Adds a follow-up item about CDN failure recovery UX. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.