Skip to content

feat: beta type-checking impl.#8

Merged
knightedcodemonkey merged 4 commits intomainfrom
bananas
Mar 17, 2026
Merged

feat: beta type-checking impl.#8
knightedcodemonkey merged 4 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 16, 2026 23:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an in-app diagnostics experience to the playground, including TypeScript-aware transpilation and an on-demand TypeScript typecheck flow, with new UI indicators for status/diagnostics severity.

Changes:

  • Add a Diagnostics drawer UI (toggle, close, clear actions) and supporting styles.
  • Introduce TypeScript runtime loading + lib .d.ts fetching to run in-browser type diagnostics.
  • Improve status styling (neutral/pending/error) and add Playwright coverage for TS stripping and new status/diagnostics behaviors.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/styles.css Adds status severity styles, diagnostics toggle/drawer styling, and a loading indicator for buttons.
src/index.html Adds Diagnostics toggle + drawer markup and a new “Typecheck” button.
src/cdn.js Adds TypeScript CDN import spec and helper to build lib .d.ts URL fallbacks.
src/app.js Implements diagnostics state/rendering, TypeScript compiler+lib loading, typecheck execution, TS-stripping transpile fallback, and status severity handling.
playwright/app.spec.ts Adds E2E coverage for TS annotation transpilation and new status/diagnostics interactions.
docs/next-steps.md Updates roadmap with modularization follow-up items.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1172 to 1173
const shouldAttemptTranspileFallback = error => error instanceof SyntaxError

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference later:

Keeping this broad as SyntaxError now intentionally to preserve TS/JSX recovery behavior. Error shape matters but it will be addressed during the planned move to oxc-transform to avoid churn and regressions. Will revisit narrowing/merging fallback errors once the new transform path is in place and covered by tests.

@knightedcodemonkey knightedcodemonkey merged commit 8c0c5f6 into main Mar 17, 2026
2 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch March 17, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants