KDS-648: KdsEmptyState Implementation #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senemdilli
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Implements KDS-648 by introducing KDS-based empty state UIs for the Python workspace and view preview, along with dependency updates to support the new components.
Changes:
- Add
KdsEmptyStateto workspace and preview components and adjust conditional rendering accordingly. - Disable KDS legacy mode in the app bootstrap.
- Bump
@knime/kds-componentsand update build/test tooling versions inpackage.json.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| org.knime.python3.scripting.nodes/js-src/src/main.ts | Disables KDS legacy mode globally to use updated KDS behavior/components. |
| org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue | Adds KDS empty state when the workspace has no temporary values. |
| org.knime.python3.scripting.nodes/js-src/src/components/PythonViewPreview.vue | Replaces legacy placeholder UI with KdsEmptyState and adds run-action buttons. |
| org.knime.python3.scripting.nodes/js-src/package.json | Updates KDS dependency and upgrades dev tooling versions (vite/vitest/cyclonedx). |
Files not reviewed (1)
- org.knime.python3.scripting.nodes/js-src/package-lock.json: Language not supported
org.knime.python3.scripting.nodes/js-src/src/components/PythonViewPreview.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Show resolved
Hide resolved
senemdilli
force-pushed
the
KDS-648-Empty-State-Implementation
branch
from
e575914 to
196c54c
Compare
senemdilli
force-pushed
the
KDS-648-Empty-State-Implementation
branch
from
196c54c to
cb58250
Compare
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonViewPreview.vue
Show resolved
Hide resolved
senemdilli
force-pushed
the
KDS-648-Empty-State-Implementation
branch
2 times, most recently
from
912ea94 to
619d7c2
Compare
KDS-648 (Empty State)
senemdilli
force-pushed
the
KDS-648-Empty-State-Implementation
branch
from
619d7c2 to
7f775af
Compare
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/__tests__/PythonWorkspace.test.ts
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonViewPreview.vue
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonViewPreview.vue
Show resolved
Hide resolved
|
org.knime.python3.scripting.nodes/js-src/src/components/__tests__/PythonWorkspace.test.ts
Outdated
Show resolved
Hide resolved
KDS-648 (Empty State)
Comment on lines
+35
to
+43
| v-if="!pythonPreviewStatus.isExecutedOnce" | ||
| headline="Run the code to see the preview" | ||
| description="Views generated by the Python script will be displayed here." | ||
| /> | ||
| <KdsEmptyState | ||
| v-else | ||
| headline="The view cannot be displayed" | ||
| description="Check the error message and re-execute the script." | ||
| /> |
There was a problem hiding this comment.
This duplicates the KdsEmptyState component and only varies headline/description. Consider rendering a single KdsEmptyState and deriving headline/description via computed values (or inline ternaries) to reduce duplication and keep the empty-state messaging easier to maintain.
Suggested change
| v-if="!pythonPreviewStatus.isExecutedOnce" | |
| headline="Run the code to see the preview" | |
| description="Views generated by the Python script will be displayed here." | |
| /> | |
| <KdsEmptyState | |
| v-else | |
| headline="The view cannot be displayed" | |
| description="Check the error message and re-execute the script." | |
| /> | |
| :headline=" | |
| pythonPreviewStatus.isExecutedOnce | |
| ? 'The view cannot be displayed' | |
| : 'Run the code to see the preview' | |
| " | |
| :description=" | |
| pythonPreviewStatus.isExecutedOnce | |
| ? 'Check the error message and re-execute the script.' | |
| : 'Views generated by the Python script will be displayed here.' | |
| " | |
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDS-648 (Empty State)