Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0369385 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kylemcd
requested review from
a team,
MikeCarbone and
andy-knock
and removed request for
a team
cjbell
approved these changes
Mar 12, 2026
kylemcd
deleted the
kyle-kno-12041-fix-nanoid-crypto-issue-with-react-native-expo
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 65.15% 65.15%
=======================================
Files 207 207
Lines 9593 9593
Branches 1250 1250
=======================================
Hits 6250 6250
Misses 3318 3318
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches the
nanoidimport in@knocklabs/clientfromnanoidtonanoid/non-secureto fix a bundling error in React Native environments. React Native users (particularly with Expo) hit a build error becausenanoid's default export depends on Node'scryptomodule, which doesn't exist in the React Native runtime. Some users have worked around this by installingexpo-cryptoas a polyfill, but this is fragile — it depends on the polyfill loading beforenanoid, which isn't guaranteed across different Expo SDK versions and build configurations. The non-secure variant usesMath.random()instead ofcrypto.getRandomValues(). The only usage ofnanoidin the client is to generate areferenceIdforFeedinstances (e.g.client_V1StGXR8_Z5jdHi6B-myT), used for internal client tracking — it doesn't serve any security purpose, so cryptographic randomness is unnecessary.