Python-home-challenge#01-MaorWeiss#14
Open
MaorW wants to merge 6 commits intoknowabli:masterfrom
MaorW:master
Open
Python-home-challenge#01-MaorWeiss#14MaorW wants to merge 6 commits intoknowabli:masterfrom MaorW:master
MaorW wants to merge 6 commits intoknowabli:masterfrom
MaorW:master
Conversation
AviadP
reviewed
Dec 3, 2019
| print(f"which has appeared {biggest_counting} times.") | ||
|
|
||
| def read_file(): | ||
| with open('/home/$USER/, 'r') as tmp_file: |
Contributor
There was a problem hiding this comment.
did you test this code? i dont think it will work with this path
| print(f"The most recurring word in the file is '{the_most_recurring_word}'") | ||
| print(f"which has appeared {biggest_counting} times.") | ||
|
|
||
| def read_file(): |
Contributor
There was a problem hiding this comment.
to get better use of your function, file name should be an argument
| return execute_file | ||
|
|
||
|
|
||
| def spilt_file(file): |
Contributor
There was a problem hiding this comment.
var name file - you are not use file here, it is string, so var name might be misleading
|
|
||
| def printing_the_recurring_word(split_words_from_file): | ||
| biggest_counting = 0 | ||
| # Creating variable for keeping the recurring value from the file # |
| printing_the_recurring_word(my_split_file) | ||
|
|
||
|
|
||
| main() |
Contributor
There was a problem hiding this comment.
plz add "if name" condition here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10 @AviadP
I accidentally deleted this repo and created a new one with the same files. A terrible mistake