Python challenge- HW#15
Open
morbitton wants to merge 4 commits intoknowabli:masterfrom
morbitton:python_challenge
Open
Python challenge- HW#15morbitton wants to merge 4 commits intoknowabli:masterfrom morbitton:python_challenge
morbitton wants to merge 4 commits intoknowabli:masterfrom
morbitton:python_challenge
Conversation
AviadP
suggested changes
Dec 3, 2019
HW python.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| #my code: | |||
|
|
|||
| with open('text.txt') as file: | |||
Contributor
There was a problem hiding this comment.
with...open... context should only include file operation
Contributor
There was a problem hiding this comment.
pls use "with..open..." context manager, as explained in class
Author
There was a problem hiding this comment.
@AviadP i change at the new file to - with open('text.txt', 'r') as file
HW python.py
Outdated
|
|
||
| with open('text.txt') as file: | ||
| List=file.read().split() | ||
| wordDict={} |
Contributor
There was a problem hiding this comment.
plz follow python style guide for variable names = this one should be "word_dict", but anyway try to chose better variable names, something that describe the purpose of this var
Author
There was a problem hiding this comment.
@AviadP I renamed it meaningful - word_counter
and in the second problem i renamed to f_read instead of List
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HomeWork Python
@AviadP