Conversation
isTravis
approved these changes
Apr 1, 2026
|
|
||
| vi.mock('utils/import/uploadAndConvertImages', async () => { | ||
| if (process.env.AWS_ACCESS_KEY_ID) { | ||
| if (process.env.INTEGRATION) { |
Member
There was a problem hiding this comment.
Where does env.INTEGRATION come from for testing? Is that just set, so it roughly says, "If this is integration testing..."?
| export const getUploadPolicy = ({ contentType }: GetUploadPolicyParams) => { | ||
| const acl = 'public-read'; | ||
| const bucket = 'assets.pubpub.org'; | ||
| const awsAccessKeyId = expect(process.env.AWS_ACCESS_KEY_ID); |
Member
There was a problem hiding this comment.
It seems like there is new default logic around env variables now. Could you just clarify how defaults work now for non-existent vars? Is it just that they'd fail type checking before the runtime, so we don't need to do these checks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
This PR adds env variable validation using Zod at startup.
This prevents a class of issues of forgetting to set important env vars, leading to tricky to debug situations (or just a bunch of extra work)
Also nice: adds more typesafety
Kind of quirky in tests, but otherwise works fine!
Test Plan
See if everything works on Duqduq
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs