Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions packages/opencode/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,20 @@ async function hasBundledSkillDirectories(root: string): Promise<boolean> {
}

async function resolveBundledSkillsRoot(): Promise<string | undefined> {
let firstExistingCandidate: string | undefined;

for (const candidate of BUNDLED_SKILL_ROOT_CANDIDATES) {
if (!await pathExists(candidate)) continue;

firstExistingCandidate ??= candidate;

if (await hasBundledSkillDirectories(candidate)) {
return candidate;
}
}

return firstExistingCandidate;
return undefined;
}

type ApplyConfigOptions = {
logger?: PluginLogger;
resolveBundledSkillsRoot?: () => Promise<string | undefined>;
};

function normalizeSkillPaths(paths: unknown): string[] {
Expand Down Expand Up @@ -145,23 +142,28 @@ export async function applyCommandsConfig(
}

export async function applySkillsConfig(cfg: Config, options?: ApplyConfigOptions) {
const bundledSkillsRoot = await resolveBundledSkillsRoot();
const bundledSkillsRoot = options?.resolveBundledSkillsRoot
? await options.resolveBundledSkillsRoot()
: await resolveBundledSkillsRoot();
const skillsConfig = cfg as ConfigWithSkillsPaths;
const normalizedPaths = normalizeSkillPaths(skillsConfig.skills?.paths);

if (!bundledSkillsRoot) {
await options?.logger?.warn("Skipping Kompass skills registration", {
reason: "No bundled skills directory found",
});

const skillsConfig = cfg as ConfigWithSkillsPaths;
if (skillsConfig.skills && "paths" in skillsConfig.skills) {
if (normalizedPaths.length > 0) {
skillsConfig.skills ??= {};
skillsConfig.skills.paths = normalizedPaths;
} else if (skillsConfig.skills && "paths" in skillsConfig.skills) {
delete skillsConfig.skills.paths;
}
return;
}

const skillsConfig = cfg as ConfigWithSkillsPaths;
skillsConfig.skills ??= {};
skillsConfig.skills.paths = normalizeSkillPaths(skillsConfig.skills.paths);
skillsConfig.skills.paths = normalizedPaths;

if (!skillsConfig.skills.paths.includes(bundledSkillsRoot)) {
skillsConfig.skills.paths.push(bundledSkillsRoot);
Expand Down
14 changes: 14 additions & 0 deletions packages/opencode/test/skills-config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,18 @@ describe("applySkillsConfig", () => {
assert.equal(cfg.skills?.paths?.length, 2);
assert.equal(typeof cfg.skills?.paths?.[1], "string");
});

test("preserves valid configured skill paths when no bundled skills root exists", async () => {
const cfg: { skills?: { paths?: unknown[] } } = {
skills: {
paths: [undefined, "", "/tmp/custom-skills"],
},
};

await applySkillsConfig(cfg as never, {
resolveBundledSkillsRoot: async () => undefined,
});

assert.deepEqual(cfg.skills?.paths, ["/tmp/custom-skills"]);
});
});
Loading