feat: add PHP 8.4 support with OCI8 extension#34
Merged
dbpolito merged 2 commits intokool-dev:mainfrom Feb 2, 2026
Merged
Conversation
- Add 4 new Docker image variants for PHP 8.4: * 8.4-oci8-nginx * 8.4-oci8-nginx-prod * 8.4-oci8-swoole-nginx * 8.4-oci8-swoole-nginx-prod - Update template to use PECL for PHP >= 8.4 * OCI8 extension no longer available in PHP core for 8.4+ * Install via PECL with automatic cleanup of build dependencies * Maintain backward compatibility with older versions using docker-php-ext - Update fwd-template.json with PHP 8.4 build configurations - Update kool.yml with PHP 8.4 build commands - Update README.md with PHP 8.4 documentation and links All images tested and verified with OCI8 3.4.1 and Oracle Client 11.2.0.4.0
dbpolito
reviewed
Feb 2, 2026
template/Dockerfile.blade.php
Outdated
| preg_match('/:(\d+\.\d+)/', $from, $matches); | ||
| $phpVersion = isset($matches[1]) ? (float)$matches[1] : 0; | ||
| @endphp | ||
| @if($phpVersion >= 8.4) |
Member
There was a problem hiding this comment.
if we really need, you could use https://www.php.net/manual/en/function.version-compare.php
like https://github.com/kool-dev/docker-php/blob/master/template/Dockerfile.blade.php#L43
but can you check if this new way works on 8.1+, if so, we can drop 8.0 and just do this way
dbpolito
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 4 new Docker image variants for PHP 8.4:
Update template to use PECL for PHP >= 8.4
Update fwd-template.json with PHP 8.4 build configurations
Update kool.yml with PHP 8.4 build commands
Update README.md with PHP 8.4 documentation and links
All images tested and verified with OCI8 3.4.1 and Oracle Client 11.2.0.4.0