This repository was archived by the owner on Jun 29, 2024. It is now read-only.
Remove requirement for passing client to models#66
Open
shalvah-gs wants to merge 1 commit intokoshilife:masterfrom
Open
Remove requirement for passing client to models#66shalvah-gs wants to merge 1 commit intokoshilife:masterfrom
shalvah-gs wants to merge 1 commit intokoshilife:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #65, when you need to initialize a model, you must pass a client instance, or else you'll get an error "client is not ready":
But there's no value to this error–to avoid it, you just need to add a boilerplate client, which is easy to forget, annoying and pointless:
This PR gets rid of this requirement. If no client is passed, a new client instance is created. It's what the user does most times anyway.