Open
Conversation
edelanghe-ledger
force-pushed
the
update-protobuf-v5
branch
from
a1395c4 to
7c2e4de
Compare
Refactoring `load_reqs` allow us more flexibility in the format of requirements we want to define and make usage of .in possible instead of the .txt. For example we can now define `protobuf>=5.28.2,<6`
Using: pip-compile-multi I tried to use the arg `--no-upgrade` but it failed to find correct dependencies.
Using: tox -e genstubs
edelanghe-ledger
force-pushed
the
update-protobuf-v5
branch
from
7c2e4de to
429db88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
The current version 3.6.1 is no longer supported by Google and so we should update to the active version.
The current active versions of protobuf goes from 5.26 to 5.29. grpcio will require at least 27.1 so let's require
protobuf>=5.27.1,<6.To specify this requirements I had to patch the setup.py to use .in files instead of the generated .txt