Skip to content

#44: Fix executor start action texts #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksi-kangas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#44: Fix executor start action texts #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/krasa/visualvm/executor/DebugVisualVMExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@

import javax.swing.*;

import com.intellij.execution.executors.DefaultDebugExecutor;
import krasa.visualvm.Resources;

import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;

import com.intellij.execution.executors.DefaultRunExecutor;

public class DebugVisualVMExecutor extends DefaultRunExecutor {
public class DebugVisualVMExecutor extends DefaultDebugExecutor {
@NonNls
public static final String EXECUTOR_ID = "Debug with VisualVM";
public static final String DEBUG_WITH_VISUAL_VM = "DebugWithVisualVM";
Expand Down Expand Up @@ -51,6 +50,11 @@ public String getStartActionText() {
return EXECUTOR_ID;
}

@Override
public @NotNull String getStartActionText(@NotNull String configurationName) {
return getStartActionText();
}

public String getContextActionId() {
// HACK: ExecutorRegistryImpl expects this to be non-null, but we don't want any context actions for every file
return getId() + " context-action-does-not-exist";
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/krasa/visualvm/executor/RunVisualVMExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ public String getStartActionText() {
return RUN_WITH_VISUAL_VM;
}

@Override
public @NotNull String getStartActionText(@NotNull String configurationName) {
return getStartActionText();
}

public String getContextActionId() {
// HACK: ExecutorRegistryImpl expects this to be non-null, but we don't want any context actions for every file
return getId() + " context-action-does-not-exist";
Expand Down