Skip to content

Clean up obsolete net7 test conditionals while preserving Classic compatibility #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Clean up obsolete net7 test conditionals while preserving Classic compatibility #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
483aaa9
Initial plan
Copilot Feb 16, 2026
f1f24b4
chore: remove dead framework-conditional branches
Copilot Feb 16, 2026
9e6b357
fix: restore Classic framework guards in shared files
Copilot Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/KubernetesClient.Tests/KubernetesJsonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ type Time struct {
Assert.Equal(56, t.Rfc3339nano.Second);
Assert.Equal(123, t.Rfc3339nano.Millisecond);

#if NET7_0_OR_GREATER
Assert.Equal(456, t.Rfc3339micro.Microsecond);
Assert.Equal(456, t.Rfc3339nano.Microsecond);
Assert.Equal(700, t.Rfc3339nano.Nanosecond);
Expand All @@ -115,7 +114,6 @@ type Time struct {
Assert.Equal(700, t.Rfc3339nanolenient7.Nanosecond);
Assert.Equal(700, t.Rfc3339nanolenient8.Nanosecond);
Assert.Equal(700, t.Rfc3339nanolenient9.Nanosecond);
#endif

}

Expand Down Expand Up @@ -189,9 +187,7 @@ public void DateTimeWithTimezoneOffsetParsesCorrectly()
Assert.Equal(16, dt.Minute);
Assert.Equal(55, dt.Second);
Assert.Equal(79, dt.Millisecond);
#if NET7_0_OR_GREATER
Assert.Equal(293, dt.Microsecond);
#endif
}

[Fact]
Expand Down
2 changes: 0 additions & 2 deletions tests/KubernetesClient.Tests/KubernetesYamlTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,6 @@ type Time struct {
Assert.Equal(56, t.Rfc3339nano.Second);
Assert.Equal(123, t.Rfc3339nano.Millisecond);

#if NET7_0_OR_GREATER
Assert.Equal(456, t.Rfc3339micro.Microsecond);
Assert.Equal(456, t.Rfc3339nano.Microsecond);
Assert.Equal(700, t.Rfc3339nano.Nanosecond);
Expand All @@ -1332,7 +1331,6 @@ type Time struct {
Assert.Equal(700, t.Rfc3339nanolenient7.Nanosecond);
Assert.Equal(700, t.Rfc3339nanolenient8.Nanosecond);
Assert.Equal(700, t.Rfc3339nanolenient9.Nanosecond);
#endif

}
}
Expand Down