Skip to content

Fix update-schedule workflow: rename branch, add proper error handling#54932

Open
Caesarsage wants to merge 1 commit intokubernetes:mainfrom
Caesarsage:fix/update-schedule-workflow
Open

Fix update-schedule workflow: rename branch, add proper error handling#54932
Caesarsage wants to merge 1 commit intokubernetes:mainfrom
Caesarsage:fix/update-schedule-workflow

Conversation

@Caesarsage
Copy link
Copy Markdown
Contributor

@Caesarsage Caesarsage commented Mar 17, 2026

The workflow has been silently failing because the stale remote branch "update-schedule" could not be force-pushed to, preventing PR creation.

Changes:

  • Rename PR branch from "update-schedule" to "auto/update-schedule"
  • Delete stale remote branch before creating PR to prevent push failures
  • Fix retry loop to properly fail the job after 3 attempts
  • Remove unnecessary fetch-depth: 0

I tried this on my own branch to confirm work flow works which created this : Caesarsage#2

my debug/test changes:
Caesarsage@201909b

closes #54940

The workflow has been silently failing because the stale remote branch
"update-schedule" could not be force-pushed to, preventing PR creation.

Changes:
- Rename PR branch from "update-schedule" to "auto/update-schedule"
- Delete stale remote branch before creating PR to prevent push failures
- Fix retry loop to properly fail the job after 3 attempts
- Remove unnecessary fetch-depth: 0
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2026
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 17, 2026
@k8s-ci-robot k8s-ci-robot requested a review from reylejano March 17, 2026 00:18
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 17, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6124ca3
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69b89dc7c83bf100087593b5
😎 Deploy Preview https://deploy-preview-54932--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Mar 17, 2026

This really needs an issue filed.

Also: before making any update, we ought to make sure that we know why the existing workflow is changing.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Mar 17, 2026

I expect that using a different branch name might fail due to rules on branch protection.

@Caesarsage
Copy link
Copy Markdown
Contributor Author

I expect that using a different branch name might fail due to rules on branch protection.

Okay, I didn't think about that. Another way would be to delete the stale update-schedule branch. The workflow should then work as-is on the next run. We could then add a step to the action to always delete the stale PR branch before creating a new one, to prevent this from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update update-schedule workflow have been failing

3 participants