Skip to content

Fix color for hovered nav bar text#54943

Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
Creativeklvn:navbar
Mar 20, 2026
Merged

Fix color for hovered nav bar text#54943
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
Creativeklvn:navbar

Conversation

@Creativeklvn
Copy link
Copy Markdown
Contributor

@Creativeklvn Creativeklvn commented Mar 17, 2026

This PR fixes the hover state of navigation links to maintain visibility when the navbar background is white.

Before:
Screenshot 2026-03-17 153802

After:
Screenshot 2026-03-17 153713

#54938

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Mar 17, 2026
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 17, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b922570
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69baef322266660008541050
😎 Deploy Preview https://deploy-preview-54943--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Mar 17, 2026

/retitle Fix color for hovered nav bar text

@k8s-ci-robot k8s-ci-robot changed the title Navbar hover Fix color for hovered nav bar text Mar 17, 2026
Comment thread assets/scss/_variables_project.scss Outdated
@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Mar 18, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 475cd2152a22580857e69c008216fb35a080afba

Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2026
@k8s-ci-robot k8s-ci-robot requested a review from lmktfy March 18, 2026 18:30
@shurup
Copy link
Copy Markdown
Member

shurup commented Mar 20, 2026

Thanks for the fix! I think we'd better merge it ASAP, since the existing bug is affecting the current UX badly.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 054a3c7004c4741a4ea2236c3cc9b26d7130936e

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Mar 20, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 95a20b2 into kubernetes:main Mar 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants