Skip to content

[DEV-1038] fix: add missing no stream case to expected revision error handling #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w1am merged 2 commits into from
Feb 3, 2026
Merged

[DEV-1038] fix: add missing no stream case to expected revision error handling #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74fcd8
readme
w1am Jan 27, 2026
4ca1758
fix: missing noStream case to expected revision error handling
w1am Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/io/kurrent/dbclient/AppendToStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io.grpc.ManagedChannel;
import io.grpc.stub.StreamObserver;


import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
Expand Down Expand Up @@ -69,6 +70,8 @@ private CompletableFuture<WriteResult> append(ManagedChannel channel, List<Event
expectedRevision = StreamState.any();
} else if (wev.getExpectedRevisionOptionCase() == StreamsOuterClass.AppendResp.WrongExpectedVersion.ExpectedRevisionOptionCase.EXPECTED_STREAM_EXISTS) {
expectedRevision = StreamState.streamExists();
} else if (wev.getExpectedRevisionOptionCase() == StreamsOuterClass.AppendResp.WrongExpectedVersion.ExpectedRevisionOptionCase.EXPECTED_NO_STREAM) {
expectedRevision = StreamState.noStream();
} else {
expectedRevision = StreamState.streamRevision(wev.getExpectedRevision());
}
Expand Down
82 changes: 69 additions & 13 deletions src/test/java/io/kurrent/dbclient/streams/AppendTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,41 +12,97 @@ public interface AppendTests extends ConnectionAware {
default void testAppendSingleEventNoStream() throws Throwable {
KurrentDBClient client = getDatabase().defaultClient();
String streamName = generateName();
String eventType = "TestEvent";
UUID eventId = UUID.randomUUID();
Foo foo = new Foo();
byte[] fooBytes = mapper.writeValueAsBytes(foo);

EventData event = EventData.builderAsJson(eventType, fooBytes)
EventData event = EventData.builderAsJson("TestEvent", fooBytes)
.metadataAsBytes(fooBytes)
.eventId(eventId)
.build();

WriteResult appendResult = client.appendToStream(
streamName,
AppendToStreamOptions.get().streamState(StreamState.noStream()),
event
).get();
streamName, AppendToStreamOptions.get().streamState(StreamState.noStream()), event).get();

Assertions.assertEquals(StreamState.streamRevision(0), appendResult.getNextExpectedRevision());

ReadResult result = client.readStream(
streamName,
ReadStreamOptions.get().fromEnd().backwards().maxCount(1)
).get();

Assertions.assertEquals(1, result.getEvents().size());
ReadResult result = client.readStream(streamName, ReadStreamOptions.get().fromEnd().backwards().maxCount(1)).get();
RecordedEvent first = result.getEvents().get(0).getEvent();
ObjectNode userMetadata = mapper.readValue(first.getUserMetadata(), ObjectNode.class);

Assertions.assertAll(
() -> Assertions.assertEquals(streamName, first.getStreamId()),
() -> Assertions.assertEquals(eventType, first.getEventType()),
() -> Assertions.assertEquals("TestEvent", first.getEventType()),
() -> Assertions.assertEquals(eventId.toString(), first.getEventId().toString()),
() -> Assertions.assertEquals(foo, mapper.readValue(first.getEventData(), Foo.class)),
() -> Assertions.assertEquals(foo, mapper.readValue(first.getUserMetadata(), Foo.class)),
() -> Assertions.assertFalse(userMetadata.has(ClientTelemetryConstants.Metadata.TRACE_ID)),
() -> Assertions.assertFalse(userMetadata.has(ClientTelemetryConstants.Metadata.SPAN_ID))
);
}

@Test
default void testAppendMultipleEventsAtOnce() throws Throwable {
KurrentDBClient client = getDatabase().defaultClient();
String streamName = generateName();
int eventCount = 5;

WriteResult result = client.appendToStream(streamName,
AppendToStreamOptions.get().streamState(StreamState.noStream()),
generateEvents(eventCount, "TestEvent").iterator()).get();

Assertions.assertEquals(StreamState.streamRevision(eventCount - 1), result.getNextExpectedRevision());
Assertions.assertEquals(eventCount, client.readStream(streamName, ReadStreamOptions.get()).get().getEvents().size());
}

@Test
default void testStreamStateOptimisticConcurrency() throws Throwable {
KurrentDBClient client = getDatabase().defaultClient();

String anyStream = generateName();
appendEvent(client, anyStream, StreamState.any());
appendEvent(client, anyStream, StreamState.any());
Assertions.assertEquals(2, client.readStream(anyStream, ReadStreamOptions.get()).get().getEvents().size());

String existsStream = generateName();
assertWrongExpectedVersion(client, existsStream, StreamState.streamExists(), StreamState.streamExists(), StreamState.noStream());
appendEvent(client, existsStream, StreamState.noStream());
appendEvent(client, existsStream, StreamState.streamExists());

String noStream = generateName();
appendEvent(client, noStream, StreamState.noStream());
assertWrongExpectedVersion(client, noStream, StreamState.noStream(), StreamState.noStream(), StreamState.streamRevision(0));

String revStream = generateName();
appendEvent(client, revStream, StreamState.noStream());
appendEvent(client, revStream, StreamState.streamRevision(0));
assertWrongExpectedVersion(client, revStream, StreamState.streamRevision(99), StreamState.streamRevision(99), StreamState.streamRevision(1));
}

default EventData createTestEvent() throws Exception {
return EventData.builderAsJson("TestEvent", mapper.writeValueAsBytes(new Foo()))
.eventId(UUID.randomUUID())
.build();
}

default void appendEvent(KurrentDBClient client, String streamName, StreamState state) throws Exception {
client.appendToStream(streamName, AppendToStreamOptions.get().streamState(state), createTestEvent()).get();
}

default void assertWrongExpectedVersion(KurrentDBClient client, String streamName, StreamState state, StreamState expectedState, StreamState actualState) {
WrongExpectedVersionException ex = Assertions.assertThrows(WrongExpectedVersionException.class, () -> {
try {
appendEvent(client, streamName, state);
} catch (java.util.concurrent.ExecutionException e) {
if (e.getCause() != null) {
throw e.getCause();
}
throw e;
}
});
Assertions.assertEquals(streamName, ex.getStreamName());
Assertions.assertEquals(expectedState, ex.getExpectedState());
Assertions.assertEquals(actualState, ex.getActualState());
}

}
Loading