Make string difference more readable

[haobug]

With this patch:

    assertEquals "deadbeef" "deadbuff"

will output like this

    ASSERT:
    expected:<deadbeef>
    ---------------^
    but was :<deadbuff>

[kward]

I agree that this output is cleaner, but this commit will change the behavior for all users, and I am hesitant to make such a change due to the wide userbase.

Alternatively, this could be controlled with a flag (variable) so that users can choose to enable it, similar to the SHUNIT_COLOR flag. Maybe call it SHUNIT_DENSITY which relates to the density of the output? Values could be 'compact' (the default) or 'comfortable' (yours).

Thoughts?

[kward]

The pull as is needs to be rewritten to align with coding standards (function name, variable names, variable cleanup, etc.).
https://github.com/kward/shunit2/wiki/Coding-standards

[haobug]

I agree that this output is cleaner, but this commit will change the behavior for all users, and I am hesitant to make such a change due to the wide userbase.

yes, I have realized that. it might break someone's code.

Alternatively, this could be controlled with a flag (variable) so that users can choose to enable it, similar to the SHUNIT_COLOR flag. Maybe call it SHUNIT_DENSITY which relates to the density of the output? Values could be 'compact' (the default) or 'comfortable' (yours).

Thoughts?

@kward could you give out some reference commit that can show me how to add a new flag compatibility?

[haobug]

The pull as is needs to be rewritten to align with coding standards (function name, variable names, variable cleanup, etc.). https://github.com/kward/shunit2/wiki/Coding-standards

I will revise the lines of modified code to align with the coding style in the commit of changing flag controlled way

[haobug]

@kward i have finished my code change revising of both styling and adding a SHUNIT_DIFF_ALIGN env variable.
the default of SHUNIT_DIFF_ALIGN is never. one can use it as following

SHUNIT_DIFF_ALIGN=always bash ut.sh