Remove deprecated encode/decode methods, fix warnings and other…#112
Remove deprecated encode/decode methods, fix warnings and other…#112kylef merged 25 commits intokylef:masterfrom
Conversation
…d method name as a deprecated method
…tween Swift 4.0 and 4.2
Remove deprecated encode/decode, fix warnings, other fixes
|
Swift 4 deprecates Interesting…are the CI builds really using Swift 4? Update: After tinkering with the Travis config, builds and tests are passing on all macOS configurations (using Xcode 9.4/Swift 4.1.2) and Update 2: Travis builds are passing again. I’ll update the configuration such that it should do the same tests as before, adding back |
Sync up LinuxMain.swift (hopefully)
swift test builds JWT and JWA, so compilation errors for those will otherwise just result in two jobs that fail for the same reason; one can still check the Travis output to see where exactly the failure is occurring
|
@jonblatho I tried out your changes, but when running |
|
@jakekrog I unfortunately don’t really have any experience with Carthage at all, let alone enough to handle issues with it. I’m sorry! |
|
@jonblatho It was actually my mistake, I didn't realize that the project file had been removed in the master branch. |
|
Is this going to be reviewed/merged any time soon? |
|
Thanks @jonblatho! |
Summary of what’s changed:
ClaimSettype will no longer need to be given explicitlydeallocate(capacity:)deprecationvalidateExpiary(leeway:)tovalidateExpiry(leeway:)— the old misspelled method is still available but deprecatedClaimSetinstead ofPayloadWith all that said, this PR alone would probably make for a decent 3.0 release given the code-breaking change at the top of the list. Perhaps also consider #99/#106; it’s a quick-and-easy change that people seem to want.