Fixed background color of dependencygraph in lightmode#700
Open
Fixed background color of dependencygraph in lightmode#700
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts dependency graph container styling so the background renders correctly in light mode (and respects dark mode) without relying on runtime next-themes checks.
Changes:
- Replaced
theme === "light" ? ... : ...background logic with Tailwinddark:classes for dependency graph wrappers. - Removed
useThemeandclassNamesusage where no longer needed (simplifies components and reduces runtime theme branching). - Standardized the dependency graph container background classes across dialogs and pages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/vex-rules/VexRuleDetailsDialog.tsx | Uses Tailwind dark: classes for graph container; removes useTheme/classNames dependency. |
| src/components/DependencyDialog.tsx | Uses Tailwind dark: classes for graph container; removes useTheme/classNames dependency. |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/refs/[assetVersionSlug]/dependency-risks/[vulnId]/page.tsx | Updates graph wrapper background classes; adjusts theme hook usage (needs cleanup). |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/refs/[assetVersionSlug]/dependencies/graph/page.tsx | Uses Tailwind dark: classes for full-page graph background; removes useTheme/classNames dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../[projectSlug]/assets/[assetSlug]/refs/[assetVersionSlug]/dependency-risks/[vulnId]/page.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: l3montree-dev/devguard#1877