Fixed search behavior: Now returning to page 1 of pagination on search#701
Open
Fixed search behavior: Now returning to page 1 of pagination on search#701
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared useDebouncedQuerySearch() hook so that changing the search term resets paginated views back to the first page, aligning search UX across all pages that rely on this hook.
Changes:
- Update
useDebouncedQuerySearch()to set thepagequery param to1wheneversearchchanges.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dboy0ZDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: l3montree-dev/devguard#1865
The added change intends to return the user to page 1 of the paginated results. I believe that should be the intended workflow instead of staying on the same page as before the search (likely staying on a page that has no results).
All components/pages that use the
useDebouncedQuerySearch()hook share this behavior, so the change was implemented directly into the hook.