Added tab whitespacing, save through hotkey and toast to config codeeditor#702
Open
Added tab whitespacing, save through hotkey and toast to config codeeditor#702
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the config file editing experience by improving keyboard ergonomics and user feedback in the config code editor UI.
Changes:
- Add Cmd/Ctrl+S save hotkey support to the CodeMirror-based editor.
- Enable indentation/whitespace insertion via the Tab key inside the editor.
- Show a success toast after successfully saving a config file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/common/ConfigFileEditor.tsx | Adds success toast on save and wires onSave handler to trigger saving via hotkey. |
| src/components/common/CodeEditor.tsx | Adds CodeMirror keymaps for Tab indentation and Mod-s save shortcut; introduces required onSave prop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented suggestions from Issue: l3montree-dev/devguard#1871