Conversation
…hecks for regions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to harden SARIF ingestion by preventing nil-pointer panics when extracting snippet/region data and by introducing a maximum-size gate for first-party SARIF uploads.
Changes:
- Added a nil check for
PhysicalLocation.Regionwhen building snippet metadata for first-party vuln ingestion. - Added a 16 MB size limit check in the SARIF upload controller path (FirstPartyVulnScan) using JSON re-marshalling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/scan_service.go | Adds guarding logic around missing SARIF Region when extracting snippet coordinates/content. |
| controllers/scan_controller.go | Adds a SARIF payload size check (16 MB) before proceeding with scan processing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timbastin
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size limit check only prevents big sarifs from being saved to the database. The fill sized data will still reach the backend server and land in memory unless prevented by ratelimiting / size limiting through a reverse-proxy or else.