Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a runtime concurrent map read and map write panic observed during org sync by serializing access to the shared Casbin RBAC enforcer/model with a mutex.
Changes:
- Introduces a package-level
sync.RWMutexto guard concurrent access to Casbin’s shared RBAC structures. - Wraps Casbin enforcer read calls with
RLock/RUnlockand mutating calls withLock/Unlock. - Guards the watcher update callback (
LoadPolicy) with the same mutex to prevent concurrent policy reload vs. enforcement operations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Tim Bastin <38261809+timbastin@users.noreply.github.com>
timbastin
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When triggering the sync for an org, sometimes concurrent routine would cause a concurrent read write panic on the rbac models underlying map. TO prevent this I added a mutex and used lock/unlock guards around each call of the enforcer functions.