fix(inventory): add state guards to dispose() and open_item()#365
Closed
robotlearning123 wants to merge 6 commits intomainfrom
Closed
fix(inventory): add state guards to dispose() and open_item()#365robotlearning123 wants to merge 6 commits intomainfrom
robotlearning123 wants to merge 6 commits intomainfrom
Conversation
robotlearning123
force-pushed
the
fix/dispose-state-guard
branch
2 times, most recently
from
b1c8f7a to
62015fc
Compare
robotlearning123
force-pushed
the
fix/dispose-state-guard
branch
from
49c097c to
063a5a5
Compare
…m, extractor, email_intake Wave 1 of test coverage improvements for lab-manager: - test_email_poller.py (NEW): 28 tests for IMAP polling, error handling, shutdown - test_documents_route_coverage.py: +48 tests for background tasks, CRUD, review, upload - test_litellm_client.py: +4 tests for load_litellm_config - test_pubchem.py: expanded test coverage - test_extractor_coverage.py: expanded test coverage - test_email_intake.py: expanded test coverage Unit test count: 1406 → 1444 (+38 net new) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- test_api_validation.py (NEW): 58 tests for email validation (74% → 96%) - test_more_ocr_coverage.py (NEW): 68 tests for OCR providers (59% → 100%) - test_extractor_coverage.py: +12 tests for intake/extractor (82% → 98%) - test_pubchem.py: +6 tests for pubchem service (90% → 100%) - test_litellm_client.py: +18 tests for litellm client (68% → 100%) - test_email_poller.py: +31 tests for email poller (78% → 99%) - test_email_intake.py: +9 tests for email intake (90% → 100%) - test_documents_route_coverage.py: clean 56 tests (removed isolation-broken classes) Unit test count: 1406 → 1626 (+220 net new) All 1626 pass, 0 failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dispose() allowed double-dispose — no status check before setting disposed. This created misleading consumption log entries with quantity_used=0. open_item() similarly allowed opening items in terminal states (disposed/deleted/depleted/expired). - dispose() now rejects items already in disposed or deleted state - open_item() now rejects items in disposed/deleted/depleted/expired - Both raise ValidationError with clear message - 8 new tests covering all terminal state transitions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
robotlearning123
force-pushed
the
fix/dispose-state-guard
branch
from
063a5a5 to
83131d1
Compare
1 task
robotlearning123
added a commit
that referenced
this pull request
Mar 29, 2026
## Summary - Add `InventoryStatus.depleted` to `open_item()` status guard - Depleted items (quantity=0) should not be openable Replaces #365 ## Test plan - [x] `tests/test_inventory_guards.py` verifies depleted items raise ValidationError Co-authored-by: Cong <72737794+robolearning123@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
dispose()allowed double-dispose with no state check.open_item()allowed opening items in terminal states (disposed, deleted, depleted, expired). Both would silently succeed, creating misleading consumption log entries.Root Cause
dispose()checked no preconditions before settingstatus=disposedand logging consumption.open_item()only checkedopened_date is not Nonebut didn't validate the item's current status.Fix
dispose()now rejects items already indisposedordeletedstateopen_item()now rejects items indisposed,deleted,depleted, orexpiredstateValidationErrorwith descriptive messageTest
8 new tests in
test_inventory_state_guard.py:🤖 Found and fixed by bug-hunter autonomous loop.