[codex] fix(inventory): handle string order status on receive#369
Merged
robotlearning123 merged 1 commit intomainfrom Mar 28, 2026
Merged
[codex] fix(inventory): handle string order status on receive#369robotlearning123 merged 1 commit intomainfrom
robotlearning123 merged 1 commit intomainfrom
Conversation
686e18a to
d3c29bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
receive_items()so it handles order statuses loaded back from the database as plain strings instead of assuming an enum instance.Root Cause
Order.statusis stored as a string field. In a fresh session, SQLModel returns values like"received"asstr, butreceive_items()calledorder.status.valuein the already-received/cancelled/deleted guard. That raisedAttributeErrorinstead of the intendedValidationError.What Changed
getattr(order.status, "value", order.status)before building the validation message.Impact
Validation
uv run pytest -q tests/test_inventory_service_coverage.py -k 'receive'