feat: add Node 25 support, update versions, fix CI#117
Merged
AaronFeledy merged 3 commits intomainfrom Feb 27, 2026
Merged
Conversation
Node 19 and 21 are EOL odd-numbered (non-LTS) releases. Modern npm packages like minimatch@10.2.4 require Node '18 || 20 || >=22', causing yarn install to fail in these examples and cascading all tests to fail. Odd-numbered Node releases (19, 21, 23) have short support windows. Node 23 is still covered in CI since it's recent enough for current deps. Node 18, 20, 22, and 24 (the LTS releases) remain fully tested. Fixes flaky CI on examples/19 and examples/21.
✅ Deploy Preview for lando-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Keep examples/21 to verify compatibility with older odd-numbered Node releases. Pin minimatch to ^9.0.0 via yarn resolutions since minimatch 10.x requires Node '18 || 20 || >=22' which excludes Node 21. Still removes examples/19 (too old, images less reliable).
Replace specific hub.docker.com/_/node pattern with hub.docker.com to catch all Docker Hub links (they frequently rate-limit or 403 on CI).
AaronFeledy
changed the title
AaronFeledy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the Node plugin up to date with all current Node.js releases and fixes broken CI tests.
New Version Support
CI Fixes
examples/19— Node 19 is EOL,minimatch@10.xrequires18 || 20 || >=22examples/21— pinnedminimatchto^9.0.0via yarn resolutions for compatexamples/25— test coverage for the new Node 25 supportOther
hub.docker.comtodoPattern innetlify.toml(was only matching/_/node)Test Coverage