Closed
Conversation
The ssl-mode=DISABLED setting was breaking connections to MySQL servers with require_secure_transport=ON. The default ssl-mode=PREFERRED behavior is appropriate as it attempts SSL without certificate verification (so self-signed certs work) but falls back gracefully, and still allows connections to servers that require SSL.
Author
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
Description
This PR fixes a regression introduced by globally disabling SSL for MySQL clients. The previous change, intended to address MySQL 5.7 self-signed certificate issues, inadvertently broke connections to MySQL 8.0+ servers requiring secure transport and removed encryption for all MySQL client connections.
This change reverts the
ssl-mode=DISABLEDsetting inlando.cnf, restoring the defaultssl-mode=PREFERREDbehavior. This default mode correctly handles self-signed certificates (by not strictly verifying them) while still attempting encrypted connections and falling back gracefully when SSL is not available. This resolves the regression and ensures secure transport is still possible where required, without reintroducing the original MySQL 5.7 issue.