fix: remove legacy prestissimo cleanup causing composer crash#240
Merged
AaronFeledy merged 3 commits intomainfrom Feb 25, 2026
Merged
fix: remove legacy prestissimo cleanup causing composer crash#240AaronFeledy merged 3 commits intomainfrom
AaronFeledy merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for lando-php ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The Docker dockerfile-release-notes link has a fragment redirect issue and jeffgeerling.com returns 301 instead of 302. Both are external sites we can't control, so mark them as known TODOs.
…erns" This reverts commit 7c58f09.
The hirak/prestissimo removal in install-composer.sh checked for a global composer.json at /var/www/.composer/ (www-data's dir) but ran `composer global remove` as root, which targets /root/.config/composer. Since commit 01586fb moved composer installation to build_as_root_internal, this script now runs as root, causing a path mismatch and crash when /var/www/.composer/composer.json exists from a previous build. Prestissimo was a Composer 1 parallel-download plugin that Composer 2 made obsolete. The cleanup code is no longer needed.
bc5db1f to
92cad25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Removes the legacy
hirak/prestissimocleanup block frominstall-composer.shthat was causing composer to crash during Laravel (and other recipe) builds.Root Cause
Commit
01586fbmoved composer installation frombuild_internaltobuild_as_root_internal, meaninginstall-composer.shnow runs as root instead of the service user (www-data).The prestissimo cleanup block checked for a global
composer.jsonat/var/www/.composer/(www-data's dir), butcomposer global removeas root targets/root/.config/composer/composer.json— which doesn't exist. This path mismatch causes:This only triggers on rebuilds where
/var/www/.composer/composer.jsonpersists from a previous build via volume mounts.Fix
Remove the prestissimo cleanup entirely.
hirak/prestissimowas a Composer 1 parallel-download plugin that Composer 2 made obsolete in 2020. The cleanup code is no longer needed.Testing
lando startwith Laravel recipelando rebuildwith persistent composer volumesNote
Low Risk
Low risk: removes an obsolete post-install cleanup step and only affects Composer install-time behavior; main risk is missing any previously relied-on global plugin removal in edge cases.
Overview
Fixes a Composer install crash by removing the legacy
hirak/prestissimoglobal cleanup fromscripts/install-composer.sh, avoiding failures when the script runs under a different user context.Updates
CHANGELOG.mdto note the fix.Written by Cursor Bugbot for commit 92cad25. This will update automatically on new commits. Configure here.