fix: remove hardcoded mysql_native_password for MySQL 8.4 compat#135
Merged
AaronFeledy merged 3 commits intomainfrom Mar 2, 2026
Merged
fix: remove hardcoded mysql_native_password for MySQL 8.4 compat#135AaronFeledy merged 3 commits intomainfrom
AaronFeledy merged 3 commits intomainfrom
Conversation
The default_authentication_plugin config variable was removed in MySQL 8.4. The bitnami image translates MYSQL_AUTHENTICATION_PLUGIN into this variable, causing a fatal startup error. The mysql plugin already handles 5.7 auth internally, so recipes don't need to set this. Fixes lando/mysql#69, lando/mysql#72
✅ Deploy Preview for lando-wordpress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MySQL 8.4 removed the
default_authentication_pluginconfig variable (deprecated in 8.0.34, removed in 8.4). The bitnami image translates theMYSQL_AUTHENTICATION_PLUGINenv var into this config entry, causing MySQL 8.4 to fail with:Changes
authentication: 'mysql_native_password'from the recipe database configlando/mysqlplugin already handles the 5.7 case internally (builders/mysql.js:42), so recipes don't need to set thisBackwards Compatibility
mysql_native_passwordfor 5.7caching_sha2_passwordby default (correct modern auth)Related
lando/mysqlto conditionally set the env varNote
Medium Risk
Changes the database service configuration to no longer force a specific MySQL auth plugin, which can affect how users authenticate across MySQL versions. Risk is moderate but scoped to database startup/auth behavior and should be covered by versioned MySQL service tests.
Overview
Fixes MySQL 8.4 containers failing to start by removing the WordPress recipe’s hardcoded
mysql_native_passworddatabaseauthenticationsetting, deferring auth behavior to the underlying MySQL service/plugin.Also updates Netlify deploy-preview link checking to ignore
hub.docker.comlinks, and documents the MySQL fix inCHANGELOG.md.Written by Cursor Bugbot for commit 3588b93. This will update automatically on new commits. Configure here.